Review TYPO3_8-7 Merged

53325[TASK] typo3/testing-framework 1.1 brings phpunit 6.2

Christian Kuhn CR +2 V +2 Hard +371 −171 updated 06/25/17, 20:21

Commit message

Switching from 1.0 to 1.1 dependency for typo3/testing-framework
brings phpunit v6.2 which comes with namespaced classes.

This change is considered non-braeking since it is only a
core require-dev dependency.

Minor changes throught the tests:
* Fixing incomplete tests for exceptions
* A couple of namespaced phpunit class usages

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 68

  1. Christian Kuhn uploaded patch set 1 06/25/17, 19:49

  2. Christian Kuhn voted on patch set 1 CR -2 06/25/17, 19:54

  3. TYPO3com voted on patch set 1 V +1 06/25/17, 19:58 Completed build in 09m 37s on Sun, 25 Jun, 09:58 PM Test Summary: 58164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-474

  4. Christian Kuhn uploaded patch set 2 06/25/17, 20:02

  5. Christian Kuhn voted on patch set 2 CR 0 06/25/17, 20:14

  6. TYPO3com voted on patch set 2 V +1 06/25/17, 20:14 Completed build in 11m 36s on Sun, 25 Jun, 10:14 PM Test Summary: 58164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-475

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 06/25/17, 20:21

  8. Gerrit merged patch set 2 06/25/17, 20:21