Review main Abandoned

53355[TASK] Set main dependencies in system exts composer.json

Christian Kuhn CR 0 V 0 Normal +98 −33 updated 10/20/17, 11:49

Commit message

The patch adds a series of require dependencies in
composer.json files of core extensions:

* Require lower level libs in ext:core - doctrine, symfony stuff, ...
* Require other low level libs if ext:core does not need them in
  specific extension: doctrine/instantiator in ext:extbase
* Require typo3/cms-core in all core extensions, except ext:core itself
* Require typo3/cms-backend in all exts that bring backend modules
* Require typo3/cms-frontend in all exts that bring frontend plugins
* Require typo3/cms-extbase in all exts that have an extbase based
  action controller
* Require typo3/cms-fluid in ext:extbase
* Require typo3/cms-saltedpasswords in ext:install

The above list is a "hard" requirement list. There are lots of further
hidden requirements, for instance further modules use the extbase
signal slot dispatcher and thus would require extbase, too. And
nearly all exts would need typo3/cms-fluid.

It is important this change does explicitely NOT aim to list all
dependencies. For ext:core, this base extension should in the end
not require other core exts, the currently existing hidden dependencies
are not added.
Also dependencies for especially ext:lang and ext:fluid are not
declared, this area needs more work.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 33

Review log 710

  1. Christian Kuhn uploaded patch set 1 06/29/17, 14:37

  2. TYPO3com voted on patch set 1 V -1 06/29/17, 14:48 Completed build in 11m 14s on Thu, 29 Jun, 04:48 PM Test Summary: 56751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12894

  3. TYPO3com voted on patch set 1 V +1 06/29/17, 14:54 Completed build in 28m 13s on Thu, 29 Jun, 04:54 PM Test Summary: 56751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12894

  4. Christian Kuhn uploaded patch set 2 07/04/17, 21:19

  5. Christian Kuhn commented on patch set 2 07/04/17, 21:21

    note: this patch is non-intrusive since composer.json of sysext currently has no meaning and is only for a future working "git split have only extension available in source that are really loaded". from current core point of view, this patch shouldn't have any side effects.
  6. TYPO3com voted on patch set 2 V +1 07/04/17, 21:30 Completed build in 11m 05s on Tue, 4 Jul, 11:30 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13004

  7. Tymoteusz Motylewski commented on patch set 2 CR +1 07/06/17, 18:37

    looks good, not sure if it can be tested somehow
  8. Georg Ringer commented on patch set 2 07/07/17, 05:36

    shouldn't that also be added some kind to ext_emconf?
  9. Christian Kuhn commented on patch set 2 CR -1 07/15/17, 16:22

    i'll rework this one.
  10. Christian Kuhn abandoned the change 10/20/17, 11:49

    abandoned - currently not working on this one and various other patches changed deps already meanwhile.