Review main Merged

53364[BUGFIX] EXT:form - fix radio button html markup

Ralf Zimmermann CR +2 V +2 Easy +20 −17 updated 07/04/17, 20:57

Commit message

Make the radio button html markup closer to
http://getbootstrap.com/css/#checkboxes-and-radios

- remove the "for" attribute from the container label tag
- add the "radio" class to the elements div wrapper
- remove the class attribute from the elements label tag

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Jörg Bösche +1
    • Mathias Brodala +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Ralf Zimmermann uploaded patch set 1 06/30/17, 08:54

  2. TYPO3com voted on patch set 1 V +1 06/30/17, 09:04 Completed build in 09m 40s on Fri, 30 Jun, 11:04 AM Test Summary: 56751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12919

  3. Mathias Brodala voted on patch set 1 CR +1 V +1 06/30/17, 09:16

  4. Jörg Bösche voted on patch set 1 CR +1 06/30/17, 18:48

  5. Wouter Wolters voted on patch set 1 CR +1 06/30/17, 18:53

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 07/04/17, 20:57

  7. Gerrit merged patch set 1 07/04/17, 20:57