Review main Merged

53366[BUGFIX] Remove not working CDATA usage in JS template file

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 07/01/17, 18:32

Commit message

The "{" character is now wrapped into f:format.raw.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Jörg Bösche +1
    • Oliver Hader +1
    • Aljoscha Weber +1
  • Verified V +2
    • Andreas Kienast +2
    • Oliver Hader +1
    • Aljoscha Weber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1215

  1. Anja Leichsenring uploaded patch set 1 06/30/17, 10:24

  2. Mathias Brodala voted on patch set 1 CR +1 06/30/17, 10:25

  3. Mathias Brodala updated the commit message in patch set 2 06/30/17, 10:25

  4. Mathias Brodala voted on patch set 2 CR +1 06/30/17, 10:25

  5. Anja Leichsenring commented on patch set 3 06/30/17, 10:29

    Published edit on patch set 2.
  6. Aljoscha Weber voted on patch set 3 CR +1 V +1 06/30/17, 10:33

  7. TYPO3com voted on patch set 1 V +1 06/30/17, 10:36 Completed build in 12m 03s on Fri, 30 Jun, 12:36 PM Test Summary: 56751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12921

  8. TYPO3com voted on patch set 2 V +1 06/30/17, 10:38 Completed build in 12m 40s on Fri, 30 Jun, 12:38 PM Test Summary: 56751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12922

  9. TYPO3com voted on patch set 3 V +1 06/30/17, 10:41 Completed build in 11m 22s on Fri, 30 Jun, 12:41 PM Test Summary: 56751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12923

  10. Oliver Hader commented on patch set 3 CR +1 V +1 06/30/17, 14:37

    The raw view-helper ensures that the special literal "{" is available again. However, I think that not interpreting CDATA in Fluid is another issue here on the XML low-level...
  11. Jörg Bösche voted on patch set 3 CR +1 06/30/17, 18:47

  12. Wouter Wolters voted on patch set 3 CR +1 06/30/17, 18:54

  13. Andreas Kienast commented on patch set 3 CR +2 V +2 07/01/17, 18:32

    What a nasty bug...
  14. Gerrit merged patch set 3 07/01/17, 18:32

  15. Andreas Kienast commented on patch set 4 07/01/17, 18:32

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 5ca11839c91f3ae1c3883ab782702353bd41bf71