53369[BUGFIX] Do not escape output of the Fluid\Widget\UriViewHelper
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1316
-
Aljoscha Weber uploaded patch set 1 06/30/17, 12:06
-
Mathias Brodala updated the commit message in patch set 2 06/30/17, 12:20
-
TYPO3com voted on patch set 1 V -1 06/30/17, 12:28 Completed build in 21m 56s on Fri, 30 Jun, 02:28 PM Test Summary: 56679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12928
-
TYPO3com voted on patch set 2 V +1 06/30/17, 12:29 Completed build in 09m 46s on Fri, 30 Jun, 02:29 PM Test Summary: 56751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12929
-
Aljoscha Weber voted on patch set 2 CR +1 V +1 07/03/17, 13:38
-
Jonas Götze voted on patch set 2 CR +1 V +1 07/03/17, 13:40
-
Andreas Kienast commented on patch set 2 CR -1 07/03/17, 14:05
Other uri-related view helpers don't need that option. The bug must be somewhere else.UriViewHelper.php:98What happens on setting the constant `PHP_QUERY_RFC3986` as fourth parameter in http_build_query()? -
Andreas Kienast commented on patch set 2 07/03/17, 14:06
TYPO3\CMS\Fluid\ViewHelpers\Widget\LinkViewHelper should be then also affected by this -
Aljoscha Weber commented on patch set 2 CR 0 V 0 07/03/17, 15:00
The LinkViewHelper extends the AbstractTagBasedViewHelper which doesn't escape it's output. -
Jonas Götze voted on patch set 2 CR 0 V 0 07/03/17, 15:48
-
Mathias Brodala updated the commit message in patch set 3 09/07/17, 13:51
-
TYPO3com voted on patch set 3 V +1 09/07/17, 14:09 Completed build in 17m 53s on Thu, 7 Sep, 04:09 PM Test Summary: 58133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14309
-
Aljoscha Weber commented on patch set 3 CR +1 V +1 10/17/17, 14:48
Tested in 8.7.8 -
Susi Moog commented on patch set 3 CR -1 10/17/17, 17:13
as discussed in core dev channel, please fix in widget template. -
Aljoscha Weber abandoned the change 10/18/17, 10:08
as discussed in core dev channel, the issue is that the widget-uri is written directly into the js-option-string in the autocomplete-wdiget template -
Damianos DIMITRIADIS commented on patch set 3 11/07/17, 09:12
Hello, May I propose the following change of the autocomplete widget template (typo3/sysext/fluid/Resources/Private/Templates/ViewHelpers/Widget/Autocomplete/Index.html), which solves the problem as far as I have tested: Line 3: jQuery("#{id}").autocomplete({ //no need for format.raw here Line 4: source: <f:format.raw>"{f:widget.uri(action:'autocomplete', ajax: 1)}"</f:format.raw>