Review main Merged

53376[TASK] Refactor implementation of PaginateWidget

Claus Due CR +2 V +2 Normal +60 −62 updated 11/06/17, 10:24

Commit message

Refactors templates to minimise the impact of using the
uncompilable PaginateWidget. By moving the Widget to
a separate partial and the body rendered by the Widget
to another partial the impact is reduced to a minimum,
because the uncompilable template has just two nodes.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Wouter Wolters +1
    • Tymoteusz Motylewski +1
    • Henning Liebe +1
    • Andreas Kienast +1
    • Jörg Bösche +1
  • Verified V +2
    • Jigal van Hemert +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1213

  1. Claus Due uploaded patch set 1 07/02/17, 00:04

  2. TYPO3com voted on patch set 1 V +1 07/02/17, 00:14 Completed build in 10m 06s on Sun, 2 Jul, 02:14 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12949

  3. Jörg Bösche voted on patch set 1 CR +1 07/03/17, 06:03

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 08/18/17, 12:01

  5. Andreas Kienast voted on patch set 1 CR +1 08/18/17, 12:12

  6. Henning Liebe voted on patch set 1 CR +1 08/28/17, 08:25

  7. Tymoteusz Motylewski commented on patch set 1 08/28/17, 14:32

    please state that it's in BE User module, currently it sounds too general.
    backport to v8 requires Benni approval, as it's in the gray zone between feature and task/bug
  8. Claus Due commented on patch set 1 08/31/17, 22:01

    Reply

    There is only this and one other occurrence so there's not really much to confuse. The other implementation, paginating TER results in EM, is already factored to this structure.

    Reply

    Correct, but to help sell the idea: the templates cannot be overridden by users and the filename is specified directly, so not even by adding a templateRootPath would it be possible to change the template that renders this partial. The only potentially affecting change is if you had a secondary partial path for the BE user module and for some reason chose this exact name for it. That use case gets broken but it is so unlikely I think the significant performance benefit (avoiding much failed recompiling of a rather large template) is worth it for the 99,9% of users who get pure benefit :)
  9. Tymoteusz Motylewski voted on patch set 1 CR +1 09/01/17, 08:37

  10. Jigal van Hemert commented on patch set 1 CR +2 V +2 11/04/17, 08:24

    @Claus: it would be worth documenting with the PaginateWidget documentation (or in a central place for all uncompilable VHs) this best practise of separating in partials. For v8 backport I'll contact Benni.
  11. Gerrit merged patch set 1 11/04/17, 08:24

  12. Jigal van Hemert commented on patch set 2 11/06/17, 10:23

    Benni said it was okay to backport to v8.
  13. Jigal van Hemert commented on patch set 2 11/06/17, 10:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 4f9d262f147e29e480dbef2e4b2187c4d0a06dff