Review main Merged

53379[TASK] Provide missing example configuration for TYPO3 on Microsoft IIS

Benjamin Kott CR +2 V +2 Normal +79 −2 updated 09/10/17, 13:41

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1316

  1. Benjamin Kott uploaded patch set 1 07/02/17, 19:35

  2. TYPO3com voted on patch set 1 V +1 07/02/17, 19:45 Completed build in 09m 44s on Sun, 2 Jul, 09:45 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12962

  3. Susi Moog commented on patch set 1 07/04/17, 05:55

    _web.config:14

    typo "composer"

    _web.config:30

    miscellaneous instead of diverse
  4. Frank Nägler commented on patch set 1 07/27/17, 11:49

    is it required to have this file in the git repository? I would prefer to have it in the documentation instead of the repository. if it "must" be located in the git, can we put into a subfolder and not into the root?
  5. Susi Moog commented on patch set 1 07/27/17, 11:56

    @frank: same as with the .htaccess files. either we put all of the server confs (apache, nginx, iis) out of the repository, or we leave all of them in there. As this is also about a secure / ideal config on the given server, I think we should leave it here.
  6. Susi Moog commented on patch set 1 07/27/17, 11:58

    _web.config:39

    platzhalter?
  7. Benjamin Kott commented on patch set 2 09/09/17, 20:45

    Published edit on patch set 1.
  8. Benjamin Kott commented on patch set 2 09/09/17, 20:46

    _web.config:14 Reply

    Done

    _web.config:30 Reply

    Done

    _web.config:39 Reply

    Done
  9. TYPO3com voted on patch set 2 V +1 09/09/17, 21:01 Completed build in 16m 33s on Sat, 9 Sep, 11:01 PM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14743

  10. Benjamin Kott uploaded patch set 3 09/10/17, 09:35

  11. TYPO3com voted on patch set 3 V +1 09/10/17, 09:49 Completed build in 14m 01s on Sun, 10 Sep, 11:49 AM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14793

  12. Benni Mack voted on patch set 3 CR +1 09/10/17, 11:01

  13. Stefan Neufeind voted on patch set 3 CR +1 09/10/17, 13:39

  14. Christian Kuhn voted on patch set 3 CR +2 V +2 09/10/17, 13:41

  15. Gerrit merged patch set 3 09/10/17, 13:41

  16. Christian Kuhn commented on patch set 4 09/10/17, 13:41

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 80857b4258439e3fc21ed6e9cd82881ac6097669