Review main Merged

53391[BUGFIX] Cache calls to SchemaManager()->listTableColumns()

Stephan Großberndt CR +2 V +2 Easy +36 −10 updated 09/09/17, 21:13

Commit message

Caching the calls SchemaManager()->listTableColumns() during runtime
leads to improved performance when doing operations on multiple files or
multiple extbase Domain/Model objects at once as the same information
does not have to be fetched over and over.

Review

  • Code review CR +2
    • Benni Mack +2
    • Sebastian Fischer +1
    • Jörg Bösche +1
    • Henning Liebe +1
    • Andreas Kienast +1
    • Philipp Gampe +1
    • Steffen Frese +1
  • Verified V +2
    • Benni Mack +2
    • Philipp Gampe +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1517

  1. Stephan Großberndt uploaded patch set 1 07/04/17, 07:54

  2. Philipp Gampe voted on patch set 1 CR +1 07/04/17, 07:59

  3. TYPO3com voted on patch set 1 V +1 07/04/17, 08:03 Completed build in 09m 33s on Tue, 4 Jul, 10:03 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12987

  4. Stephan Großberndt commented on patch set 1 07/04/17, 08:09

    Using an extbase repository to create ~4100 records this leads to an improved performance of 9.4 seconds instead of 66 seconds
  5. Stephan Großberndt uploaded patch set 2 07/05/17, 09:15

  6. Stephan Großberndt commented on patch set 2 07/05/17, 09:17

    Make sure that even if another table is configured at some time in ProcessedFileRepository the cached information is correct by caching per table. Thanks to Andreas for the suggestion.
  7. TYPO3com voted on patch set 2 V +1 07/05/17, 09:26 Completed build in 10m 21s on Wed, 5 Jul, 11:26 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13016

  8. Andreas Kienast voted on patch set 2 CR +1 07/05/17, 09:32

  9. Philipp Gampe voted on patch set 2 CR +1 07/06/17, 09:51

  10. Sebastian Fischer voted on patch set 2 CR +1 07/10/17, 07:36

  11. Henning Liebe voted on patch set 2 CR +1 07/10/17, 08:24

  12. Philipp Gampe voted on patch set 2 V +1 07/14/17, 12:47

  13. Jörg Bösche voted on patch set 2 CR +1 08/13/17, 20:49

  14. Steffen Frese voted on patch set 2 CR +1 08/14/17, 09:43

  15. Benni Mack voted on patch set 2 CR +2 V +2 09/09/17, 21:12

  16. Gerrit merged patch set 2 09/09/17, 21:12

  17. Benni Mack commented on patch set 3 09/09/17, 21:13

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 6ebf63776f7ce7a4dba26535f7144b4b94c054eb