Review main Merged

53396[BUGFIX] EXT:indexed_search: Dont add stat record for empty search

Daniel Goerz CR +2 V +2 Easy +7 −2 updated 10/17/17, 23:35

Commit message

Review

  • Code review CR +2
    • Susi Moog +2
    • Christian Kuhn +1
    • Sascha Rademacher +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Daniel Goerz uploaded patch set 1 07/04/17, 12:10

  2. Daniel Goerz updated the commit message in patch set 2 07/04/17, 12:10

  3. Andreas Kienast commented on patch set 2 07/04/17, 12:16

    Hard to evaluate by reading, thus only a soft -1

    SearchController.php:806

    IMO that condition is unsafe. If $searchWord is empty, but $searchWords is not empty, the conditions doesn't match anymore andf we get the same error.
  4. Daniel Goerz commented on patch set 2 07/04/17, 12:21

    SearchController.php:806 Reply

    This does not lead to any error, only to pointless database records. If either of the two variables is not empty the database record is no longer completely pointless. However, since $searchWords depends of $this->getSword() as well (if I saw that correctly) they may be always both empty or both filled. But this is indexed-search after all. So I wont be to sure about that. :)
  5. TYPO3com voted on patch set 1 V -1 07/04/17, 12:21 Completed build in 11m 38s on Tue, 4 Jul, 02:21 PM Test Summary: 1 of 57127 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12992

  6. TYPO3com voted on patch set 2 V +1 07/04/17, 12:25 Completed build in 14m 27s on Tue, 4 Jul, 02:25 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12993

  7. Wolfgang Klinger commented on patch set 2 07/14/17, 16:09

    SearchController.php:806 Reply

    $searchWords is extracted from $this->sword (see getSearchWords), so it's enough to check if the argument $searchWords is empty imho
  8. Daniel Goerz commented on patch set 2 07/14/17, 18:56

    SearchController.php:806 Reply

    That might be true, but without context this method receives two relevant arguments for this check and it does not know (and does not care) how and where these arguments were generated.
  9. Jörg Bösche commented on patch set 2 09/15/17, 11:08

    In my opinion this is a relevant ticket for the optimization of the extension. How are things going on?
  10. Sascha Rademacher commented on patch set 2 CR +1 09/25/17, 08:40

    I agree with Daniel Goerz.
  11. Christian Kuhn voted on patch set 2 CR +1 10/17/17, 23:11

  12. Christian Kuhn voted on patch set 2 V +1 10/17/17, 23:11

  13. Susi Moog voted on patch set 2 CR +2 V +2 10/17/17, 23:15

  14. Gerrit merged patch set 2 10/17/17, 23:15

  15. Christian Kuhn commented on patch set 3 10/17/17, 23:35

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ef77b08f7425e63256c29bb0b718e363b0466577