Review main Merged

53410[BUGFIX] Replace empty value constants in TypoScript Object-Browser

Pascal Hinz CR +2 V +2 Easy +1 −1 updated 07/14/17, 20:32

Commit message

After the constants replacement was changed to a regular expression,
the expression doesn't match empty value constants and leaves the
markers untouched. With this bugfix the regular expression also
replaces empty values.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Sven Külpmann +1
  • Verified V +2
    • Jigal van Hemert +2
    • Sven Külpmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1216

  1. Pascal Hinz uploaded patch set 1 07/05/17, 12:37

  2. TYPO3com voted on patch set 1 V +1 07/05/17, 12:47 Completed build in 10m 00s on Wed, 5 Jul, 02:47 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13024

  3. Andreas Kienast updated the commit message in patch set 2 07/05/17, 12:54

  4. TYPO3com voted on patch set 2 V +1 07/05/17, 13:04 Completed build in 10m 15s on Wed, 5 Jul, 03:04 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13025

  5. Jörg Bösche commented on patch set 2 CR +1 V +1 07/10/17, 09:36

    Verified in T3 v9-dev and 8.7.3. Thanks for the understandable description of the problem with screenshots and how to reproduce it.
  6. Andreas Kienast commented on patch set 2 CR -1 07/10/17, 09:38

    "Resolves" and "Related" refer to the same ticket. Either drop "Related" or insert the correct ticket number.
  7. Pascal Hinz updated the commit message in patch set 3 07/12/17, 08:53

  8. TYPO3com voted on patch set 3 V +1 07/12/17, 09:03 Completed build in 10m 31s on Wed, 12 Jul, 11:03 AM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13092

  9. Wouter Wolters voted on patch set 3 CR +1 07/13/17, 18:22

  10. Wolfgang Klinger commented on patch set 3 CR +1 V +1 07/13/17, 21:09

    Some typos in the text: replacment -> replacement, empy -> empty, the … replace empty -> the … replaces empty
  11. Pascal Hinz updated the commit message in patch set 4 07/14/17, 16:47

  12. TYPO3com voted on patch set 4 V +1 07/14/17, 19:46 Completed build in 5h 27m 55s on Fri, 14 Jul, 09:46 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13177

  13. Sven Külpmann voted on patch set 4 CR +1 V +1 07/14/17, 20:30

  14. Jigal van Hemert voted on patch set 4 CR +2 V +2 07/14/17, 20:32

  15. Gerrit merged patch set 4 07/14/17, 20:32

  16. Jigal van Hemert commented on patch set 5 07/14/17, 20:32

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 33ef00198f3b4c4917d65ad1ae66794f4d5c7928