Review TYPO3_8-7 Merged

53417[BUGFIX] Early return in checkValueForInternalReferences

Markus Klein CR +2 V +2 Easy +3 −1 updated 07/06/17, 12:18

Commit message

If an empty field is passed to checkValueForInternalReferences
in the DataHandler class - there is no need to process the
field since it's not a "real" DB field.

An early return ensures that the method is not executed
unnecessarily and for Flexforms.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Markus Klein commented on patch set 1 07/06/17, 11:48

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 07/06/17, 11:59 Completed build in 10m 46s on Thu, 6 Jul, 01:59 PM Test Summary: 58200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-521

  3. Markus Klein voted on patch set 1 CR +2 V +2 07/06/17, 12:18

  4. Gerrit merged patch set 1 07/06/17, 12:18