Review main Merged

53424[BUGFIX] Allow cloning of the QueryBuilder

Tymoteusz Motylewski CR +2 V +2 Normal +80 −0 updated 07/15/17, 16:44

Commit message

In order to be able to implement pagination
it has to be possible to clone QueryBuilder.

Doctrine query builder already supports cloning,
so it's just about allowing it in our wrapper.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wolfgang Klinger +1
  • Verified V +2
    • Christian Kuhn +2
    • Wolfgang Klinger +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1114

  1. Tymoteusz Motylewski uploaded patch set 1 07/08/17, 15:40

  2. TYPO3com voted on patch set 1 V +1 07/08/17, 15:51 Completed build in 10m 51s on Sat, 8 Jul, 05:51 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13049

  3. Tymoteusz Motylewski uploaded patch set 2 07/08/17, 16:08

  4. TYPO3com voted on patch set 2 V +1 07/08/17, 16:19 Completed build in 10m 52s on Sat, 8 Jul, 06:19 PM Test Summary: 56787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13050

  5. Sascha Rademacher commented on patch set 2 CR +1 07/10/17, 08:30

    Looks good to me
  6. Jörg Bösche voted on patch set 2 CR +1 07/10/17, 09:22

  7. Wouter Wolters commented on patch set 2 07/13/17, 11:18

    QueryBuilder.php:1098

    one space too much
  8. Marc Wöhlken voted on patch set 2 CR +1 V +1 07/14/17, 22:42

  9. Tymoteusz Motylewski commented on patch set 3 07/15/17, 08:41

    Published edit on patch set 2.
  10. TYPO3com voted on patch set 3 V +1 07/15/17, 08:48 Completed build in 06m 44s on Sat, 15 Jul, 10:48 AM Test Summary: 19052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13226

  11. Wolfgang Klinger voted on patch set 3 CR +1 V +1 07/15/17, 14:04

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 07/15/17, 16:44

  13. Gerrit merged patch set 3 07/15/17, 16:44

  14. Christian Kuhn commented on patch set 4 07/15/17, 16:44

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 576cbc925dddd9d6c2475ca209e40aa73b4e2c71