Review TYPO3_8-7 Merged

53439[BUGFIX] Ensure absolute paths for &eID=dumpFile

Markus Klein CR +2 V +2 Easy +2 −1 updated 12/14/17, 20:05

Commit message

When using realurl (or other extensions modifying the
path of the frontend) then index.php may be linked not
to PATH_site and needs to be taken into account.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Wolfgang Klinger +1
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2224

  1. Markus Klein commented on patch set 1 07/11/17, 10:54

    Cherry Picked from branch master.
  2. Markus Klein commented on patch set 1 CR -2 07/11/17, 10:55

    Will take care of this a bit later. Will make sure that the release notes contain an extra hint for this.
  3. TYPO3com voted on patch set 1 V +1 07/11/17, 11:09 Completed build in 15m 02s on Tue, 11 Jul, 01:09 PM Test Summary: 58212 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-535

  4. Tymoteusz Motylewski commented on patch set 1 07/12/17, 07:12

    there was a regression reported in the master review. Would be great if the backport contains the fix already.
  5. Markus Klein commented on patch set 1 07/12/17, 08:12

    Yep. I have that on my radar and I keep my -2
  6. Xavier Perseguers commented on patch set 1 07/19/17, 07:50

    anything to do here?
  7. Markus Klein commented on patch set 1 07/24/17, 05:46

    @Xavier: We need to fix the regression in master first!
  8. Xavier Perseguers commented on patch set 1 07/24/17, 06:05

    @Markus: I see no regression ticket linked so I don't know what it is all about.
  9. Markus Klein commented on patch set 1 07/24/17, 06:12

    Well, correct. Helmut did not create a forge ticket yet as it seems, but clearly noted the things in the master patch. Since everyone got the notices from the master patch, I did not comment anything here.
  10. Xavier Perseguers commented on patch set 1 CR -2 08/24/17, 07:12

    Be sure to merge additional follow-up from here: https://review.typo3.org/#/c/53789/
  11. Stephan Großberndt commented on patch set 1 09/07/17, 08:03

    ping
  12. Markus Klein uploaded patch set 2 10/26/17, 23:14

  13. Markus Klein commented on patch set 2 10/26/17, 23:15

    Incorporated changes from followup of master patch
  14. Markus Klein commented on patch set 2 V +1 10/26/17, 23:18

    Still has to wait for master-followup
  15. TYPO3com voted on patch set 2 V +1 10/26/17, 23:27 Completed build in 13m 14s on Fri, 27 Oct, 01:27 AM Test Summary: 57599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1117

  16. Stephan Großberndt commented on patch set 2 12/13/17, 08:29

    Master-Followup was merged on Nov 1.
  17. Markus Klein voted on patch set 2 CR 0 12/13/17, 09:13

  18. Markus Klein voted on patch set 2 CR +1 12/13/17, 09:13

  19. Stefan Neufeind commented on patch set 2 12/13/17, 09:55

    @Xavier: please reconsider your vote, if I see the history correct
  20. Xavier Perseguers voted on patch set 2 CR 0 12/13/17, 10:31

  21. Stefan Neufeind voted on patch set 2 CR +1 12/13/17, 11:29

  22. Wolfgang Klinger voted on patch set 2 CR +1 12/14/17, 16:50

  23. Markus Klein voted on patch set 2 V +2 CR +2 12/14/17, 20:05

  24. Markus Klein merged patch set 3 12/14/17, 20:05