53454[TASK] Remove unused ViewHelpers of EXT:install
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Markus Klein +1
- Wouter Wolters +1
- Frans Saris +1
-
Verified V +2
- Jigal van Hemert +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/install/Classes/ViewHelpers/File/ImageDimensionViewHelper.phpdeleted+0 −90
- typo3/sysext/install/Classes/ViewHelpers/File/SizeViewHelper.phpdeleted+0 −83
- typo3/sysext/install/Classes/ViewHelpers/Format/CropViewHelper.php1deleted+0 −84
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/AllConfiguration/SubSection.html+1 −1
Review log 89
-
Georg Ringer uploaded patch set 1 07/12/17, 13:35
-
TYPO3com voted on patch set 1 V +1 07/12/17, 13:47 Completed build in 12m 29s on Wed, 12 Jul, 03:47 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13096
-
Frans Saris voted on patch set 1 CR +1 07/12/17, 13:57
-
Wouter Wolters voted on patch set 1 CR +1 07/12/17, 18:47
-
Markus Klein commented on patch set 1 CR -1 07/12/17, 18:52
-
Georg Ringer commented on patch set 1 07/13/17, 04:32
that was in those times when the FE was really needed, see https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_7-6/typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php#L139 but now standalone fluid doesn't know about simulating FE for cropping -
Markus Klein commented on patch set 1 CR +1 V +1 07/13/17, 05:09
Right. I was irritated by the ContentObjectRenderer instance, but it actually just uses "utility" functions crop/cropHtml, which have no dependencies to the class. -
Jigal van Hemert voted on patch set 1 CR +2 V +2 07/13/17, 11:02
-
Gerrit merged patch set 1 07/13/17, 11:02
CropViewHelper.php:22