Review main Merged

53454[TASK] Remove unused ViewHelpers of EXT:install

Georg Ringer CR +2 V +2 Hard +1 −258 updated 07/13/17, 11:02

Commit message

The following ViewHelpers are not used and can be removed:

- file.size
- file.imageDimension

The ViewHelper format.crop of EXT:install can be replace by the one of
fluid.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Frans Saris +1
  • Verified V +2
    • Jigal van Hemert +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 89

  1. Georg Ringer uploaded patch set 1 07/12/17, 13:35

  2. TYPO3com voted on patch set 1 V +1 07/12/17, 13:47 Completed build in 12m 29s on Wed, 12 Jul, 03:47 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13096

  3. Frans Saris voted on patch set 1 CR +1 07/12/17, 13:57

  4. Wouter Wolters voted on patch set 1 CR +1 07/12/17, 18:47

  5. Markus Klein commented on patch set 1 CR -1 07/12/17, 18:52

    CropViewHelper.php:22

    IMO there was a reason for using this viewhelper
  6. Georg Ringer commented on patch set 1 07/13/17, 04:32

    that was in those times when the FE was really needed, see https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_7-6/typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php#L139 but now standalone fluid doesn't know about simulating FE for cropping
  7. Markus Klein commented on patch set 1 CR +1 V +1 07/13/17, 05:09

    Right. I was irritated by the ContentObjectRenderer instance, but it actually just uses "utility" functions crop/cropHtml, which have no dependencies to the class.
  8. Jigal van Hemert voted on patch set 1 CR +2 V +2 07/13/17, 11:02

  9. Gerrit merged patch set 1 07/13/17, 11:02