53457[!!!][TASK] Remove content object JSMENU
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Benjamin Kluge +1
- Hannes Lau +1
-
Verified V +2
- Susi Moog +2
- Benjamin Kluge +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Breaking-81847-RemoveJSMENU.rst1new+49 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/JavaScriptMenuContentObject.phpdeleted+0 −185
- typo3/sysext/frontend/Classes/ContentObject/Menu/MenuContentObjectFactory.php+0 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+0 −4
- typo3/sysext/frontend/Resources/Public/JavaScript/jsfunc.menu.jsdeleted+0 −122
- typo3/sysext/t3editor/Resources/Private/tsref.xml1+3 −119
- typo3/sysext/t3editor/Resources/Public/JavaScript/parse_typoscript/tokenizetyposcript.js+0 −3
Review log 1518
-
Georg Ringer uploaded patch set 1 07/13/17, 06:54
-
TYPO3com voted on patch set 1 V +1 07/13/17, 07:05 Completed build in 10m 28s on Thu, 13 Jul, 09:05 AM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13099
-
Wolfgang Klinger commented on patch set 1 CR +1 07/13/17, 20:18
-
Ralf Merz commented on patch set 1 CR +1 V +1 07/14/17, 22:22
Before patch a JSMENU has been rendered. I put one simple JSMENU in page.20 in TS. After applying the patch, the JSMENU doesn't render anymore. So I think it´s good. -
Philipp Gampe commented on patch set 1 07/14/17, 22:39
Breaking-81847-RemoveJSMENU.rst:12objects -
Philipp Gampe commented on patch set 2 07/14/17, 22:43
Published edit on patch set 1. -
Philipp Gampe commented on patch set 2 CR +1 V +1 07/14/17, 22:43
Fixed the comments -
TYPO3com voted on patch set 2 V +1 07/14/17, 22:53 Completed build in 09m 58s on Sat, 15 Jul, 12:53 AM Test Summary: 19020 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13216
-
Wolfgang Klinger voted on patch set 2 CR +1 07/14/17, 22:53
-
Ralf Merz voted on patch set 2 CR +1 V +1 07/15/17, 12:23
-
Wouter Wolters voted on patch set 2 CR +1 07/15/17, 12:28
-
Georg Ringer uploaded patch set 3 07/16/17, 13:55
-
TYPO3com voted on patch set 3 V +1 07/16/17, 14:06 Completed build in 10m 26s on Sun, 16 Jul, 04:06 PM Test Summary: 56859 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13275
-
Hannes Lau voted on patch set 3 CR +1 07/16/17, 15:32
-
Benjamin Kluge voted on patch set 3 V +1 07/17/17, 07:26
-
Benjamin Kluge voted on patch set 3 CR +1 07/17/17, 07:38
-
Susi Moog voted on patch set 3 CR +2 V +2 07/17/17, 07:41
-
Gerrit merged patch set 3 07/17/17, 07:41
tsref.xml:2929