Review main Merged Breaking

53457[!!!][TASK] Remove content object JSMENU

Georg Ringer CR +2 V +2 Hard +52 −434 updated 07/17/17, 07:41

Commit message

Using the JSMENU is outdated and therefore removed.

Review

  • Code review CR +2
    • Susi Moog +2
    • Benjamin Kluge +1
    • Hannes Lau +1
  • Verified V +2
    • Susi Moog +2
    • Benjamin Kluge +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1518

  1. Georg Ringer uploaded patch set 1 07/13/17, 06:54

  2. TYPO3com voted on patch set 1 V +1 07/13/17, 07:05 Completed build in 10m 28s on Thu, 13 Jul, 09:05 AM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13099

  3. Wolfgang Klinger commented on patch set 1 CR +1 07/13/17, 20:18

    tsref.xml:2929

    Remove the empty lines
  4. Ralf Merz commented on patch set 1 CR +1 V +1 07/14/17, 22:22

    Before patch a JSMENU has been rendered. I put one simple JSMENU in page.20 in TS. After applying the patch, the JSMENU doesn't render anymore. So I think it´s good.
  5. Philipp Gampe commented on patch set 1 07/14/17, 22:39

    Breaking-81847-RemoveJSMENU.rst:12

    objects
  6. Philipp Gampe commented on patch set 2 07/14/17, 22:43

    Published edit on patch set 1.
  7. Philipp Gampe commented on patch set 2 CR +1 V +1 07/14/17, 22:43

    Fixed the comments
  8. TYPO3com voted on patch set 2 V +1 07/14/17, 22:53 Completed build in 09m 58s on Sat, 15 Jul, 12:53 AM Test Summary: 19020 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13216

  9. Wolfgang Klinger voted on patch set 2 CR +1 07/14/17, 22:53

  10. Ralf Merz voted on patch set 2 CR +1 V +1 07/15/17, 12:23

  11. Wouter Wolters voted on patch set 2 CR +1 07/15/17, 12:28

  12. Georg Ringer uploaded patch set 3 07/16/17, 13:55

  13. TYPO3com voted on patch set 3 V +1 07/16/17, 14:06 Completed build in 10m 26s on Sun, 16 Jul, 04:06 PM Test Summary: 56859 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13275

  14. Hannes Lau voted on patch set 3 CR +1 07/16/17, 15:32

  15. Benjamin Kluge voted on patch set 3 V +1 07/17/17, 07:26

  16. Benjamin Kluge voted on patch set 3 CR +1 07/17/17, 07:38

  17. Susi Moog voted on patch set 3 CR +2 V +2 07/17/17, 07:41

  18. Gerrit merged patch set 3 07/17/17, 07:41