Review main Merged

53458[TASK] Mark EXT:rsaauth as deprecated

Georg Ringer CR +2 V +2 Normal +137 −2 updated 01/15/18, 11:18

Commit message

Only https can really secure a connection. Therefore rsaauth
should be marked as deprecated. An additional report checks the
usage of the extension and https.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Andreas Kienast +1
  • Verified V +2
    • Stefan Neufeind +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 3039

Show 1114 earlier messages
  1. Georg Ringer uploaded patch set 1 07/13/17, 09:57

  2. TYPO3com voted on patch set 1 V -1 07/13/17, 09:58 Completed build in 08s on Thu, 13 Jul, 11:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13103

  3. Mathias Brodala commented on patch set 2 07/13/17, 10:13

    Published edit on patch set 1.
  4. Mathias Brodala commented on patch set 2 07/13/17, 10:14

    Small RST tweaks.
  5. TYPO3com voted on patch set 2 V -1 07/13/17, 10:14 Completed build in 08s on Thu, 13 Jul, 12:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13104

  6. Mathias Brodala commented on patch set 3 07/13/17, 10:18

    Published edit on patch set 2.
  7. Mathias Brodala commented on patch set 3 07/13/17, 10:18

    Small message tweaks.
  8. TYPO3com voted on patch set 3 V -1 07/13/17, 10:18 Completed build in 08s on Thu, 13 Jul, 12:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13105

  9. Mathias Brodala commented on patch set 3 V -1 07/13/17, 10:25

    This also needs a change in the "saltedpasswords" item of the SecurityStatus. Currently when disabling EXT:rssauth, that status reports "SaltedPasswords is used without any transfer encryption, this means your passwords are sent in plain text. Please install rsaauth to secure your passwords submits."
  10. Markus Klein commented on patch set 3 CR -2 07/13/17, 18:16

    I disagree on that change and even veto! Please add your full reasoning to the forge ticket. Besides that the patch is totally incomplete as all the references to that ext in felogin and BE login must be removed too.
  11. Georg Ringer commented on patch set 3 07/15/17, 07:04

    @markus: see main ticket https://forge.typo3.org/issues/80018. and as it is a depreacation, the login still of course should work and I wouldnt throw a deprecation info at every login in be/fe
  12. Markus Klein commented on patch set 3 CR 0 10/04/17, 14:05

    after thinking about this for a long time. I raise me -2. details will follow
  13. Stefan Neufeind commented on patch set 3 12/11/17, 08:43

    ping?
  14. Stefan Neufeind commented on patch set 3 12/11/17, 08:47

    Further discussion on decisions.typo3.org maybe? @Markus: You meant to throw in -2? Please add your concerns. Personally I also prefer having rsaauth as a base-layer of "encryption".
  1. Markus Klein commented on patch set 3 12/11/17, 16:29

    As I posted to Helmut in Slack, I raised my -2 here as I now see the points made in terms of effectiveness in security. On top of that, we see major improvements to our JS and Authentication code base, where this complicates things a lot. Removing it, therefore has more benefits than downsides.
  2. Anja Leichsenring uploaded patch set 4 01/14/18, 18:36

  3. TYPO3com voted on patch set 4 V -1 01/14/18, 18:36 Completed build in 07s on Sun, 14 Jan, 07:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18322

  4. Anja Leichsenring commented on patch set 4 V +1 CR +1 01/14/18, 18:36

    rebased.
  5. Anja Leichsenring uploaded patch set 5 01/14/18, 18:37

  6. Anja Leichsenring voted on patch set 5 V +1 CR +1 01/14/18, 18:37

  7. TYPO3com voted on patch set 5 V -1 01/14/18, 18:43 Completed build in 05m 49s on Sun, 14 Jan, 07:43 PM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18323

  8. Anja Leichsenring uploaded patch set 6 01/14/18, 18:48

  9. TYPO3com voted on patch set 6 V +1 01/14/18, 18:53 Completed build in 04m 11s on Sun, 14 Jan, 07:53 PM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18325

  10. Anja Leichsenring voted on patch set 6 V +1 CR +1 01/14/18, 18:55

  11. Markus Klein commented on patch set 7 01/14/18, 23:45

    Published edit on patch set 6.
  12. Markus Klein commented on patch set 8 01/14/18, 23:48

    Published edit on patch set 7.
  13. TYPO3com voted on patch set 7 V +1 01/14/18, 23:50 Completed build in 04m 34s on Mon, 15 Jan, 12:50 AM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18327

  14. Markus Klein voted on patch set 8 CR +1 01/14/18, 23:50

  15. TYPO3com voted on patch set 8 V +1 01/14/18, 23:53 Completed build in 04m 13s on Mon, 15 Jan, 12:53 AM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18328

  16. Stefan Neufeind voted on patch set 8 CR +1 01/15/18, 03:43

  17. Andreas Kienast uploaded patch set 9 01/15/18, 07:06

  18. Andreas Kienast voted on patch set 9 V +1 CR +1 01/15/18, 07:07

  19. TYPO3com voted on patch set 9 V +1 01/15/18, 07:14 Completed build in 07m 40s on Mon, 15 Jan, 08:14 AM Test Summary: 28705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18329

  20. Stefan Neufeind voted on patch set 9 CR +1 01/15/18, 07:36

  21. Stefan Neufeind voted on patch set 9 V +2 CR +2 01/15/18, 07:41

  22. Stefan Neufeind merged patch set 10 01/15/18, 07:41

  23. Nicole Hummel commented on patch set 10 01/15/18, 09:08

    Post -1 Is there any reason why rsaauth was deprecated but is still installed (active) on a fresh installation?
  24. Stefan Neufeind commented on patch set 10 01/15/18, 11:04

    @Nicole: valid point. I didn't test a new install. Do we consider it save to have it disabled by default, even when on http? Activating it to get "some security" offers a false sense of security, which we wanted to prevent by deprecating it right?
  25. Stefan Neufeind commented on patch set 10 01/15/18, 11:18

    deactivating EXT in factory-default: https://review.typo3.org/55363