Review main Merged

53471[TASK] Move PageInformationController & TranslationStatusController

Georg Ringer CR +2 V +2 Normal +59 −35 updated 08/14/17, 13:16

Commit message

Move the mentioned controllers from EXT:frontend to EXT:info as
those belongs there.

Review

  • Code review CR +2
    • Susi Moog +2
    • Jörg Bösche +1
  • Verified V +2
    • Susi Moog +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1420

  1. Georg Ringer uploaded patch set 1 07/14/17, 09:38

  2. TYPO3com voted on patch set 1 V -1 07/14/17, 09:38 Completed build in 08s on Fri, 14 Jul, 11:38 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13146

  3. Wolfgang Klinger commented on patch set 1 CR -1 07/14/17, 10:19

    composer.json:25

    There's a , too much here … invalid json
  4. Georg Ringer uploaded patch set 2 07/14/17, 12:03

  5. TYPO3com voted on patch set 2 V -1 07/14/17, 12:03 Completed build in 18s on Fri, 14 Jul, 02:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13155

  6. Wolfgang Klinger voted on patch set 2 CR +1 V +1 07/14/17, 12:23

  7. Georg Ringer uploaded patch set 3 07/14/17, 12:25

  8. TYPO3com voted on patch set 3 V +1 07/14/17, 12:36 Completed build in 10m 49s on Fri, 14 Jul, 02:36 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13158

  9. Wolfgang Klinger voted on patch set 3 CR +1 V +1 07/14/17, 15:55

  10. Georg Ringer uploaded patch set 4 08/04/17, 07:30

  11. TYPO3com voted on patch set 4 V -1 08/04/17, 07:30 Completed build in 09s on Fri, 4 Aug, 09:30 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13564

  12. Georg Ringer uploaded patch set 5 08/04/17, 07:34

  13. TYPO3com voted on patch set 5 V -1 08/04/17, 07:48 Completed build in 14m 44s on Fri, 4 Aug, 09:48 AM Test Summary: 12 of 3658 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13565

  14. Georg Ringer uploaded patch set 6 08/04/17, 07:59

  15. TYPO3com voted on patch set 6 V +1 08/04/17, 08:10 Completed build in 11m 17s on Fri, 4 Aug, 10:10 AM Test Summary: 57414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13566

  16. Jörg Bösche commented on patch set 6 08/07/17, 10:40

    ext_tables.php:24

    EXT:frontend? Shouldn't this key also be moved to EXT:info?

    ext_tables.php:30

    EXT:frontend? Shouldn't this key also be moved to EXT:info?
  17. Georg Ringer commented on patch set 6 08/14/17, 10:41

    ext_tables.php:24 Reply

    which would mean that all translations get lost ... woudn't do that (yet)
  18. Jörg Bösche commented on patch set 6 CR +1 V +1 08/14/17, 10:55

    ext_tables.php:24 Reply

    Okay.

    ext_tables.php:30 Reply

    Done
  19. Susi Moog voted on patch set 6 CR +2 V +2 08/14/17, 13:16

  20. Gerrit merged patch set 6 08/14/17, 13:16