Review main Merged

53472[TASK] Correct composer.json files of system extensions

Georg Ringer CR +2 V +2 Easy +47 −0 updated 07/17/17, 09:37

Commit message

- add autoload-dev if missing
- add class-alias-map if missing

Review

  • Code review CR +2
    • Susi Moog +2
    • Jörg Bösche +1
  • Verified V +2
    • Susi Moog +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1823

  1. Georg Ringer uploaded patch set 1 07/14/17, 12:19

  2. Mathias Brodala commented on patch set 1 CR -1 07/14/17, 12:26

    I'd like to have Helmut comment on this.

    composer.json:23

    Does it really make sense to set this everywhere? From what I see it enforces the loader to be available all the time, even if no aliases are defined, to allow for additional aliases added at runtime. This would only make sense for entry point packages like EXT:frontend and EXT:backend. Correct me if I'm wrong.
  3. TYPO3com voted on patch set 1 V -1 07/14/17, 12:31 Completed build in 11m 09s on Fri, 14 Jul, 02:31 PM Test Summary: 12 of 3655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13157

  4. Georg Ringer commented on patch set 2 07/14/17, 12:40

    Published edit on patch set 1.
  5. Georg Ringer uploaded patch set 3 07/14/17, 12:45

  6. Mathias Brodala voted on patch set 3 CR +1 07/14/17, 12:48

  7. TYPO3com voted on patch set 2 V +1 07/14/17, 12:50 Completed build in 10m 24s on Fri, 14 Jul, 02:50 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13159

  8. TYPO3com voted on patch set 3 V +1 07/14/17, 12:55 Completed build in 10m 20s on Fri, 14 Jul, 02:55 PM Test Summary: 56775 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13160

  9. Philipp Gampe commented on patch set 3 CR -1 07/14/17, 12:59

    found some more issues
  10. Philipp Gampe voted on patch set 3 CR +1 V +1 07/14/17, 13:18

  11. Jörg Bösche voted on patch set 3 CR +1 07/14/17, 22:41

  12. Helmut Hummel commented on patch set 3 07/14/17, 23:22

    Should be backport such changes to 8.7?
  13. Georg Ringer commented on patch set 3 07/15/17, 08:17

    @helmut: as there will be no split done for 8.7, IMO it is not needed there
  14. Georg Ringer updated the commit message in patch set 4 07/15/17, 10:35

  15. TYPO3com voted on patch set 4 V +1 07/15/17, 10:43 Completed build in 08m 16s on Sat, 15 Jul, 12:43 PM Test Summary: 19048 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13231

  16. Philipp Gampe voted on patch set 4 CR +1 V +1 07/16/17, 08:51

  17. Wouter Wolters voted on patch set 4 CR +1 07/16/17, 11:18

  18. Susi Moog uploaded patch set 5 07/17/17, 07:33

  19. TYPO3com voted on patch set 5 V +1 07/17/17, 07:45 Completed build in 12m 01s on Mon, 17 Jul, 09:45 AM Test Summary: 56859 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13280

  20. Jörg Bösche voted on patch set 5 CR +1 V +1 07/17/17, 07:46

  21. Susi Moog voted on patch set 5 CR +2 V +2 07/17/17, 09:37

  22. Gerrit merged patch set 5 07/17/17, 09:37

  23. Susi Moog commented on patch set 6 07/17/17, 09:37

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d0776fa5a88f5f95591d4c073187a2a28c48ce8e