Review main Merged

53478[BUGFIX] Allow comma in config.linkVars values

Sascha Egerer CR +2 V +2 Normal +147 −1 updated 07/15/17, 08:13

Commit message

The config.linkVars TypoScript setting is splitted by comma.
This will fail if the optional value, wrapped by braces,
does contain a comma.
The string must only be splitted by commas that are not inside
of braces.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wolfgang Klinger +1
    • Frank Nägler +1
    • Jörg Bösche +1
  • Verified V +2
    • Georg Ringer +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1216

  1. Sascha Egerer uploaded patch set 1 07/14/17, 16:02

  2. TYPO3com voted on patch set 1 V -1 07/14/17, 16:02 Completed build in 13s on Fri, 14 Jul, 06:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13171

  3. Sascha Egerer uploaded patch set 2 07/14/17, 16:36

  4. TYPO3com voted on patch set 2 V -1 07/14/17, 16:46 Completed build in 10m 44s on Fri, 14 Jul, 06:46 PM Test Summary: 7 of 57223 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13175

  5. Frank Nägler voted on patch set 2 CR +1 V +1 07/14/17, 17:21

  6. TYPO3com voted on patch set 2 V +1 07/14/17, 17:23 Completed build in 58m 21s on Fri, 14 Jul, 07:23 PM Test Summary: 56859 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13175

  7. Susi Moog commented on patch set 2 CR -1 07/14/17, 21:37

    TypoScriptFrontendController.php:2830

    please add strict type hints / return types.
  8. Susi Moog voted on patch set 2 V +1 07/14/17, 21:37

  9. Sascha Egerer uploaded patch set 3 07/14/17, 21:53

  10. TYPO3com voted on patch set 3 V +1 07/14/17, 22:01 Completed build in 08m 12s on Sat, 15 Jul, 12:01 AM Test Summary: 19048 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13208

  11. Jörg Bösche voted on patch set 3 CR +1 07/14/17, 22:46

  12. Wolfgang Klinger voted on patch set 3 CR +1 07/14/17, 22:49

  13. Frank Nägler voted on patch set 3 CR +1 V +1 07/15/17, 07:32

  14. Georg Ringer voted on patch set 3 CR +2 V +2 07/15/17, 08:13

  15. Gerrit merged patch set 3 07/15/17, 08:13

  16. Georg Ringer commented on patch set 4 07/15/17, 08:13

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit a540b81a5b5efe446ad4d1534eceb4877c7baa87