53488[FEATURE] Render additionalAttributes and data-* attr in media renderer
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Sascha Rademacher +1
- Frank Nägler +1
- Henning Liebe +1
- Jörg Bösche +1
-
Verified V +2
- Georg Ringer +2
- Sascha Rademacher +1
- Henning Liebe +1
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/core/Classes/Resource/Rendering/AudioTagRenderer.php5+10 −0
- typo3/sysext/core/Classes/Resource/Rendering/VideoTagRenderer.php+10 −0
- typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php+10 −0
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php+9 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-81741-AudioVideoYouTubeVimeoAdditionalAttributes.rstnew+29 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/AudioTagRendererTest.php+16 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php+10 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+42 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+42 −0
Review log 3244
Show 1219 earlier messages
-
Markus Hölzle uploaded patch set 1 07/14/17, 20:23
-
TYPO3com voted on patch set 1 V +1 07/14/17, 20:32 Completed build in 08m 58s on Fri, 14 Jul, 10:32 PM Test Summary: 19020 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13190
-
Jörg Bösche commented on patch set 1 CR -1 07/17/17, 09:20
Missing RST file. I'm on it! -
Jörg Bösche uploaded patch set 2 07/17/17, 09:23
-
TYPO3com voted on patch set 2 V -1 07/17/17, 09:37 Completed build in 13m 46s on Mon, 17 Jul, 11:37 AM Test Summary: 56871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13289
-
Jörg Bösche uploaded patch set 3 07/17/17, 09:56
-
TYPO3com voted on patch set 3 V +1 07/17/17, 10:06 Completed build in 09m 48s on Mon, 17 Jul, 12:06 PM Test Summary: 56877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13294
-
Jörg Bösche uploaded patch set 4 07/24/17, 14:49
-
TYPO3com voted on patch set 4 V +1 07/24/17, 15:00 Completed build in 10m 56s on Mon, 24 Jul, 05:00 PM Test Summary: 56979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13412
-
Jörg Bösche commented on patch set 5 07/25/17, 07:13
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V +1 07/25/17, 07:24 Completed build in 10m 06s on Tue, 25 Jul, 09:24 AM Test Summary: 56982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13420
-
Henning Liebe voted on patch set 5 CR +1 V +1 07/25/17, 13:09
-
Benjamin Kluge commented on patch set 5 CR +1 V +1 07/25/17, 22:00
AudioTagRenderer.php:79Why not extract this? Or use GeneralUtility::implodeAttributes -
Jörg Bösche uploaded patch set 6 07/26/17, 06:19
-
Jörg Bösche commented on patch set 5 07/26/17, 06:21
Thank you for pointing that out. I implemented it in the affected classes.AudioTagRenderer.php:79ReplyDone -
TYPO3com voted on patch set 6 V +1 07/26/17, 06:30 Completed build in 10m 52s on Wed, 26 Jul, 08:30 AM Test Summary: 56982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13431
-
Jörg Bösche uploaded patch set 7 07/26/17, 07:52
-
Benjamin Kluge voted on patch set 7 CR +1 07/26/17, 08:02
-
TYPO3com voted on patch set 7 V -1 07/26/17, 08:13 Completed build in 20m 49s on Wed, 26 Jul, 10:13 AM Test Summary: 1 of 57346 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13432
-
TYPO3com voted on patch set 7 V +1 07/26/17, 08:19 Completed build in 47m 05s on Wed, 26 Jul, 10:19 AM Test Summary: 56982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13432
-
Henning Liebe voted on patch set 7 CR +1 V +1 07/31/17, 07:11
-
Benjamin Kluge voted on patch set 7 V +1 07/31/17, 07:13
-
Christian Müllenhagen commented on patch set 7 08/11/17, 11:52
This seems to be a lot of code duplication. Why not move the functionality to a separate class (e.g. AdditionalDataAttributesHandler) and then use it in the renderers? -
Georg Ringer updated the commit message in patch set 8 08/14/17, 10:50
-
Georg Ringer commented on patch set 8 CR +1 V +1 08/14/17, 10:51
I would not add an additional dependency for that, IMO fine. however features don't get into older branches -
Jörg Bösche voted on patch set 8 CR +1 V +1 08/14/17, 10:52
-
TYPO3com voted on patch set 8 V +1 08/14/17, 11:00 Completed build in 09m 53s on Mon, 14 Aug, 01:00 PM Test Summary: 57498 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13685
-
Henning Liebe voted on patch set 8 CR +1 V +1 08/14/17, 11:06
-
Christian Müllenhagen commented on patch set 8 08/14/17, 11:14
> I would not add an additional dependency for that, IMO fine. > however features don't get into older branches @Georg Ringer: Can you explain why? -
Frank Nägler commented on patch set 8 CR -1 08/18/17, 14:04
my comments are valid also for the other rendererAudioTagRenderer.php:81please set the second parameter of implodeAttributes to true, to ensure a proper escaping.AudioTagRenderer.php:85please use htmlspecialchars here to prevent XSS -
Jan Stockfisch commented on patch set 8 08/21/17, 09:02
> (2 comments) > > my comments are valid also for the other renderer I'm on it. -
Jan Stockfisch uploaded patch set 9 08/21/17, 09:38
-
Jan Stockfisch commented on patch set 9 CR -1 08/21/17, 09:50
AudioTagRenderer.php:85colleague of mine made a good point to not encode the enitre value but only the $key and $value. I'll fix that for the other TagRenderer too. -
TYPO3com voted on patch set 9 V +1 08/21/17, 09:57 Completed build in 18m 50s on Mon, 21 Aug, 11:57 AM Test Summary: 57659 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13855
-
Jan Stockfisch uploaded patch set 10 08/21/17, 10:03
-
TYPO3com voted on patch set 10 V -1 08/21/17, 10:27 Completed build in 23m 56s on Mon, 21 Aug, 12:27 PM Test Summary: 1 of 58022 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13857
-
TYPO3com voted on patch set 10 V +1 08/21/17, 13:03 Completed build in 3h 23m 34s on Mon, 21 Aug, 03:03 PM Test Summary: 57659 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13857
-
Jörg Bösche voted on patch set 10 CR +1 V +1 08/21/17, 14:00
-
Frank Nägler voted on patch set 10 CR +1 08/23/17, 07:59
-
Sascha Rademacher voted on patch set 10 CR +1 V +1 08/28/17, 08:38
-
Henning Liebe voted on patch set 10 CR +1 V +1 08/28/17, 08:47
-
Georg Ringer voted on patch set 10 CR +2 V +2 08/28/17, 19:01
-
Gerrit merged patch set 10 08/28/17, 19:01
-
Claus Due commented on patch set 11 08/28/17, 21:32
I'm just freestyling here, but since your stated intention is to duplicate the behavior of the Fluid TagBuilder... then why don't you add a method to the FileRendererInterface which accepts a TagBuilder instance and assigns the attributes to it? That would give you automatic support for all of these data- attributes and even more special features like forcing a self-closing tag. It would also mean that people can affect it from the outside if they re-configure the TagBuilder after you return if from the FileRenderer. Obviously, the ViewHelpers then render the TagBuilder and return the tag. Just an idea, but one that could save you a lot of duplication and be more in sync with the Fluid API you're trying to support ;)