Review TYPO3_8-7 Merged

53491[BUGFIX] Replace empty value constants in TypoScript Object-Browser

Jigal van Hemert CR +2 V +2 Easy +1 −1 updated 07/14/17, 20:44

Commit message

After the constants replacement was changed to a regular expression,
the expression doesn't match empty value constants and leaves the
markers untouched. With this bugfix the regular expression also
replaces empty values.

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2

Issues 1

Files 1

Review log 45

  1. Jigal van Hemert commented on patch set 1 07/14/17, 20:32

    Cherry Picked from branch master.
  2. Jigal van Hemert commented on patch set 1 CR +2 V +2 07/14/17, 20:33

    Merged as straight backport. No code changes in this area.
  3. Gerrit merged patch set 1 07/14/17, 20:33

  4. Jigal van Hemert commented on patch set 2 07/14/17, 20:33

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 2ecfa85274852d4241132e065a6ecc9f8db3406e
  5. TYPO3com commented on patch set 1 07/14/17, 20:44 Completed build in 12m 07s on Fri, 14 Jul, 10:44 PM Test Summary: 19473 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-559