Review main Merged

53498[BUGFIX] Install tool fatal errors at select database action

Markus Hölzle CR +2 V +2 Easy +16 −1 updated 07/31/17, 09:36

Commit message

Catch the fatal database exceptions in installation progress
"DatabaseSelect" and show a error message.

Review

  • Code review CR +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Wolfgang Klinger +1
    • Jan Stockfisch +1
    • Henning Liebe +1
    • Jörg Bösche +1
    • Philipp Gampe +1
  • Verified V +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Henning Liebe +1
    • Jörg Bösche +1
    • Philipp Gampe +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1719

  1. Markus Hölzle uploaded patch set 1 07/14/17, 21:21

  2. TYPO3com voted on patch set 1 V +1 07/14/17, 21:29 Completed build in 08m 33s on Fri, 14 Jul, 11:29 PM Test Summary: 19020 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13202

  3. Wolfgang Klinger voted on patch set 1 CR +1 07/14/17, 23:10

  4. Philipp Gampe voted on patch set 1 CR +1 V +1 07/16/17, 09:17

  5. Jörg Bösche voted on patch set 1 CR +1 V +1 07/17/17, 07:52

  6. Mathias Schreiber commented on patch set 1 CR -1 07/17/17, 08:01

    DatabaseSelect.html:15

    shouldn't this be a foreach? I mean if we add error logging, then there could be multiple errors, right?
  7. Markus Hölzle commented on patch set 1 07/17/17, 09:09

    DatabaseSelect.html:15 Reply

    This is a caught exception ;-) Can we catch multiple exceptions?
  8. Mathias Schreiber commented on patch set 1 07/17/17, 10:24

    DatabaseSelect.html:15 Reply

    if the catch block assigns them to a stack, of course :)
  9. Markus Hölzle uploaded patch set 2 07/17/17, 14:28

  10. Wolfgang Klinger voted on patch set 2 CR +1 07/17/17, 14:38

  11. TYPO3com voted on patch set 2 V +1 07/17/17, 14:38 Completed build in 09m 37s on Mon, 17 Jul, 04:38 PM Test Summary: 56877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13299

  12. Mathias Schreiber voted on patch set 2 CR +1 V +1 07/17/17, 15:28

  13. Philipp Gampe voted on patch set 2 CR +1 V +1 07/17/17, 23:19

  14. Jörg Bösche voted on patch set 2 CR +1 V +1 07/20/17, 06:44

  15. Jan Stockfisch voted on patch set 2 CR +1 07/22/17, 19:53

  16. Henning Liebe voted on patch set 2 CR +1 V +1 07/31/17, 09:23

  17. Susi Moog voted on patch set 2 CR +2 V +2 07/31/17, 09:36

  18. Gerrit merged patch set 2 07/31/17, 09:36

  19. Susi Moog commented on patch set 3 07/31/17, 09:36

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit e07ba7bf8044fdc043592d9473c0524513ebe64f