Review main Merged

53501[TASK] Add attribute "placeholder" to PasswordViewHelper

Daniel Diesenreither CR +2 V +2 Easy +1 −0 updated 07/14/17, 22:09

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Philipp Parzer +1
    • Daniel Maier +1
  • Verified V +2
    • Frank Nägler +2
    • Philipp Parzer +1
    • Daniel Maier +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Daniel Diesenreither uploaded patch set 1 07/14/17, 21:59

  2. Frank Nägler updated the commit message in patch set 2 07/14/17, 21:59

  3. Frank Nägler voted on patch set 2 CR +1 V +1 07/14/17, 22:00

  4. TYPO3com voted on patch set 1 V -1 07/14/17, 22:07 Completed build in 08m 17s on Sat, 15 Jul, 12:07 AM Test Summary: 1 of 19144 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13209

  5. TYPO3com voted on patch set 2 V +1 07/14/17, 22:08 Completed build in 08m 31s on Sat, 15 Jul, 12:08 AM Test Summary: 19020 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13210

  6. Philipp Parzer voted on patch set 2 CR +1 V +1 07/14/17, 22:08

  7. Frank Nägler voted on patch set 2 CR +2 V +2 07/14/17, 22:09

  8. Daniel Maier voted on patch set 2 CR +1 V +1 07/14/17, 22:09

  9. Gerrit merged patch set 2 07/14/17, 22:09

  10. Frank Nägler commented on patch set 3 07/14/17, 22:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 490606ce8c55ba8b28feed743ba1d89455f3ba49