Review main Merged

53526[BUGFIX] Execute TCA group data provider after columns override

Sascha Egerer CR +2 V +2 Normal +23 −28 updated 09/18/18, 19:14

Commit message

The TCA group dataprovider is currently executet very early and before
the ColumnsOverride dataprovider. Because of that it is not possible
to override settings of a tca field of type group. The DataProviders
have been reorderd so that the GroupDataProvider is executed at a later point.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Sascha Egerer uploaded patch set 1 07/15/17, 17:23

  2. TYPO3com voted on patch set 1 V -1 07/15/17, 17:36 Completed build in 13m 11s on Sat, 15 Jul, 07:36 PM Test Summary: 1 of 57235 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13256

  3. Sascha Egerer updated the commit message in patch set 2 07/24/17, 10:19

  4. TYPO3com voted on patch set 2 V +1 07/24/17, 10:31 Completed build in 11m 55s on Mon, 24 Jul, 12:31 PM Test Summary: 56913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13403

  5. Christian Kuhn commented on patch set 2 CR -1 09/16/18, 23:16

    ping. this patch should be more likely possible with a series of simplifications in data provider handling and site config that happened meanwhile. i'll likely update it and get it ready before v9 lts ... -1 working on it, soon ...
  6. Christian Kuhn uploaded patch set 3 09/18/18, 18:49

  7. Christian Kuhn commented on patch set 3 V +1 CR +1 09/18/18, 18:57

    ok. i rebased this one and checked some FAL scenarious with that. it should be ok to do.
  8. Christian Kuhn commented on patch set 3 09/18/18, 18:57

    however, i'm relatively sure this patch will give additional headaches in v8, so i wouldn't back port it.
  9. TYPO3com voted on patch set 3 V +1 09/18/18, 19:03 Completed build in 13m 03s on Tue, 18 Sep, 09:03 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28294

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 09/18/18, 19:14

  11. Andreas Kienast merged patch set 4 09/18/18, 19:14