Review main Merged

53555[BUGFIX] Attach CKEditor instance to RteLinkBrowser Modal, so it can be found

Johannes Schlier CR +2 V +2 Easy +17 −10 updated 07/25/17, 14:25

Commit message

Previously if the RteLinkBrowser was called from a CKEditor instance that
is within an extra iframe, the CKEditor instance could not be found.
Attaching it directly to the Modal fixes this.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Johannes Schlier uploaded patch set 1 07/20/17, 13:11

  2. TYPO3com voted on patch set 1 V +1 07/20/17, 13:21 Completed build in 10m 18s on Thu, 20 Jul, 03:21 PM Test Summary: 56877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13350

  3. Mathias Brodala commented on patch set 1 CR -1 07/20/17, 13:23

    typo3link.js:129

    Please install an EditorConfig plugin or use an editor which supports it. And fix the indentation here. ;-)

    RteLinkBrowser.js:36

    Same here.
  4. Johannes Schlier commented on patch set 2 07/20/17, 13:42

    Published edit on patch set 1.
  5. Johannes Schlier commented on patch set 2 07/20/17, 13:44

    Oh, you're right. I didn't notice the wrong indentation - this had not occurred to me in my previous TYPO3 commits. I fixed it in the second patch set.
  6. TYPO3com voted on patch set 2 V +1 07/20/17, 14:02 Completed build in 20m 37s on Thu, 20 Jul, 04:02 PM Test Summary: 56877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13355

  7. Benni Mack voted on patch set 2 V +1 07/20/17, 16:43

  8. Wouter Wolters voted on patch set 2 CR +1 07/20/17, 16:47

  9. Benni Mack voted on patch set 2 CR +2 07/25/17, 06:23

  10. Georg Ringer voted on patch set 2 CR +2 V +2 07/25/17, 14:24

  11. Gerrit merged patch set 2 07/25/17, 14:24

  12. Georg Ringer commented on patch set 3 07/25/17, 14:25

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit c284c7f5d4f6d6c0bed3113dcac5b2d71a0a7358