Review main Merged

53565[BUGFIX] Do not detect single select fields as relation

Helmut Hummel CR +2 V +2 Easy +32 −1 updated 08/08/17, 05:07

Commit message

With https://review.typo3.org/50879/ all TCA select fields
are detected as relation to many, even when they are configured
as simple static select.

This leads to the row value to be pre-set as string (to hold comma
separated values), which leads to an exception in MySQL Strict Mode
when the select value field is defined as integer.

Therefore only detect renderType === selectMultipleSideBySide
as relational field

Review

  • Code review CR +2
    • Georg Ringer +2
    • Tymoteusz Motylewski +1
    • Henning Liebe +1
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Tymoteusz Motylewski +1

Issues 1

Files 2

Review log 1214

  1. Helmut Hummel uploaded patch set 1 07/21/17, 15:11

  2. TYPO3com voted on patch set 1 V +1 07/21/17, 15:21 Completed build in 10m 17s on Fri, 21 Jul, 05:21 PM Test Summary: 56883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13377

  3. Markus Klein commented on patch set 1 07/21/17, 16:41

    Render type tree could also be a relation to many
  4. Markus Klein updated the commit message in patch set 2 07/21/17, 16:42

  5. Markus Klein commented on patch set 2 CR -1 07/21/17, 16:42

    I'm sure renderType="selectTree" needs to be taken care of too
  6. TYPO3com voted on patch set 2 V +1 07/21/17, 16:52 Completed build in 10m 14s on Fri, 21 Jul, 06:52 PM Test Summary: 56883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13378

  7. Helmut Hummel uploaded patch set 3 08/03/17, 08:57

  8. Helmut Hummel commented on patch set 3 08/03/17, 08:57

    Fixed
  9. Benni Mack voted on patch set 3 CR +1 08/03/17, 12:46

  10. Henning Liebe voted on patch set 3 CR +1 08/07/17, 08:14

  11. Tymoteusz Motylewski commented on patch set 3 CR +1 V +1 08/07/17, 21:01

    Solved the issue for me when trying to insert new record from Extbase, which has a simple integer field configured in TCA like: 'config' => array( 'type' => 'select', 'renderType' => 'selectSingle', 'items' => array( array('label1', 1), array('label12', 2), array('label14', 4), array('label18', 8) ), Without the patch I've got errors like "#1470230766: Incorrect integer value: '' for column 'status' at row 1"
  12. Georg Ringer voted on patch set 3 CR +2 V +2 08/08/17, 05:07

  13. Gerrit merged patch set 3 08/08/17, 05:07

  14. Georg Ringer commented on patch set 4 08/08/17, 05:07

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit bf2004a3c1c1adcf88ae650c19ccdcc9d7153e18