53573[BUGFIX] Prevent error with DateTimePicker on IE/Edge
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Wouter Wolters +1
- Wittkiel Gruppe +1
- Jörg Bösche +1
-
Verified V +2
- Xavier Perseguers +2
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1112
-
Xavier Perseguers uploaded patch set 1 07/24/17, 07:17
-
Xavier Perseguers voted on patch set 1 CR +1 V +1 07/24/17, 07:22
-
TYPO3com voted on patch set 1 V +1 07/24/17, 07:27 Completed build in 10m 28s on Mon, 24 Jul, 09:27 AM Test Summary: 56877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13396
-
Wouter Wolters voted on patch set 1 CR +1 07/24/17, 07:35
-
Wittkiel Gruppe voted on patch set 1 CR +1 07/24/17, 08:19
-
Jörg Bösche commented on patch set 1 CR +1 V +1 07/25/17, 08:39
Verified on Windows 8.1 with IE11.0.9600.16384 and T3 v9-dev (master) -
Xavier Perseguers voted on patch set 1 CR +2 V +2 07/25/17, 12:49
-
Gerrit merged patch set 1 07/25/17, 12:49
-
Xavier Perseguers commented on patch set 2 07/25/17, 12:50
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit c2483f445a39864bf063c7e5f32f0f69a5ac5856 -
Markus Klein commented on patch set 2 07/25/17, 12:58
DateTimePicker.js:29I disagree on that fix actually. This should be typeof window.opener !== 'undefined' && window.opener !== null (strict comparison, explicit check on known values, no side effects) -
Xavier Perseguers commented on patch set 2 07/25/17, 13:00
DateTimePicker.js:29Replywhat do you suggest? Backport on 8.7 is not merged yet -
Markus Klein commented on patch set 2 07/25/17, 13:16
Merge it as is in 8.7, it has been tested like that. Will at some point maybe take a look at the DateTimePicker code again.