Review main Merged

53575[BUGFIX] Respect lowercase „as“ in quoteIdentifiersForSelect

Frank Nägler CR +2 V +2 Easy +28 −1 updated 07/24/17, 10:15

Commit message

QueryBuilder->quoteIdentifiersForSelect() now supports lowercase
and mixedcase „as“ to detect alias names for fields.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Frank Nägler uploaded patch set 1 07/24/17, 09:39

  2. TYPO3com voted on patch set 1 V +1 07/24/17, 09:48 Completed build in 09m 21s on Mon, 24 Jul, 11:48 AM Test Summary: 56913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13400

  3. Christian Kuhn updated the commit message in patch set 2 07/24/17, 10:03

  4. Christian Kuhn voted on patch set 2 CR +1 V +1 07/24/17, 10:05

  5. Jan Helke voted on patch set 2 CR +1 V +1 07/24/17, 10:06

  6. TYPO3com voted on patch set 2 V +1 07/24/17, 10:13 Completed build in 10m 21s on Mon, 24 Jul, 12:13 PM Test Summary: 56913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13401

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 07/24/17, 10:13

  8. Gerrit merged patch set 2 07/24/17, 10:14

  9. Christian Kuhn commented on patch set 3 07/24/17, 10:15

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 3ef4bb356a0fd8e75f5faec72710e0f81edc3f14