Review main Merged

53604[BUGFIX] Always hide the loading spinner of System Information

Andreas Kienast CR +2 V +2 Easy +3 −1 updated 07/27/17, 07:28

Commit message

If the AJAX request that fetches information for the System Information
toolbar item fails for whatever reason, the spinner is now removed.

This may happen when the session times out and the re-login modal is shown
for a longer period.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 07/27/17, 05:40

  2. TYPO3com voted on patch set 1 V +1 07/27/17, 05:52 Completed build in 11m 52s on Thu, 27 Jul, 07:52 AM Test Summary: 56916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13453

  3. Jörg Bösche commented on patch set 1 CR +1 V +1 07/27/17, 07:17

    Verified on master (v9). If someone wants to adjust the behavior. Code manipulation in: \TYPO3\CMS\Backend\Backend\ToolbarItems\SystemInformationToolbarItem::renderMenuAction --> Add "$response = $response->withStatus(400);" before the return statement is executed.
  4. Christian Kuhn voted on patch set 1 CR +2 V +2 07/27/17, 07:27

  5. Gerrit merged patch set 1 07/27/17, 07:27

  6. Christian Kuhn commented on patch set 2 07/27/17, 07:28

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 34bb42403e42186ff3bb9bf5d70fd123fd8d74c8