Review main Merged

53610[BUGFIX] Changed logical operator.

TYPO3com CR +2 V +2 Easy +1 −1 updated 11/27/17, 17:21

Commit message

As the Exception says: It is not allowed to have a section without a type
OR a type without a section. So it is not allowed to have one without the
other, but it's allowed to have both or none of them. --> This is a
EXCLUSIVE OR situation.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jonathan IROULIN +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 710

  1. TYPO3com uploaded patch set 1 07/27/17, 08:34

  2. TYPO3com voted on patch set 1 V -1 07/27/17, 08:34 Completed build in 09s on Thu, 27 Jul, 10:34 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13456

  3. Susi Moog commented on patch set 2 07/27/17, 09:37

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 07/27/17, 09:48 Completed build in 10m 47s on Thu, 27 Jul, 11:48 AM Test Summary: 56916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13458

  5. Mathias Brodala commented on patch set 2 07/27/17, 10:14

    Could someone actually mention the exception message somewhere? It cannot be found neither in the commit message nor the Forge report nor the Github PR.
  6. Jonathan IROULIN commented on patch set 2 11/27/17, 13:11

    > Could someone actually mention the exception message somewhere? It > cannot be found neither in the commit message nor the Forge report > nor the Github PR. I think the exception is on line 145 : `'Broken data structure on field name ' . $fieldName . '. section without type or vice versa is not allowed', 1440685208`
  7. Jonathan IROULIN voted on patch set 2 CR +1 11/27/17, 13:14

  8. Susi Moog commented on patch set 2 CR +1 V +1 11/27/17, 13:29

    that worked before because the case both are set was handled in the if branch above and none set does not cause an exception, but it's cleaner to use xor here.
  9. Christian Kuhn voted on patch set 2 CR +2 V +2 11/27/17, 17:21

  10. Gerrit merged patch set 2 11/27/17, 17:21