Review main Merged

53613[BUGFIX] Prevent PHP warning on entering an empty install tool password

Markus Hölzle CR +2 V +2 Easy +10 −5 updated 07/31/17, 08:27

Commit message

Show a useful message if an empty install tool password is entered.

Review

  • Code review CR +2
    • Susi Moog +2
    • Sascha Rademacher +1
    • Sascha Egerer +1
    • Wouter Wolters +1
    • Henning Liebe +1
    • Jörg Bösche +1
  • Verified V +2
    • Susi Moog +2
    • Sascha Rademacher +1
    • Sascha Egerer +1
    • Henning Liebe +1
    • Jörg Bösche +1
    • Renzo Bauen +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Markus Hölzle uploaded patch set 1 07/28/17, 10:31

  2. TYPO3com voted on patch set 1 V +1 07/28/17, 10:42 Completed build in 10m 55s on Fri, 28 Jul, 12:42 PM Test Summary: 56916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13463

  3. Sascha Egerer commented on patch set 1 CR -1 07/28/17, 10:47

    AbstractController.php:215

    That change could also lead to a wired message. If your password is "0" (which of course should never ever be the case) you'll get a error message that you should enter your password. Instead of using "empty" i would add an additional "strlen" to the "isset" check.
  4. Sascha Egerer uploaded patch set 2 07/28/17, 14:00

  5. TYPO3com voted on patch set 2 V +1 07/28/17, 14:10 Completed build in 10m 50s on Fri, 28 Jul, 04:10 PM Test Summary: 56916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13466

  6. Renzo Bauen commented on patch set 2 V +1 07/28/17, 14:14

    I tested patch set 2. It works fine vor me. Thanks and best Regards, Renzo
  7. Wouter Wolters voted on patch set 2 CR +1 07/28/17, 17:39

  8. Sascha Egerer voted on patch set 2 CR +1 V +1 07/28/17, 19:42

  9. Sascha Rademacher voted on patch set 2 CR +1 V +1 07/31/17, 07:33

  10. Henning Liebe voted on patch set 2 CR +1 V +1 07/31/17, 07:52

  11. Jörg Bösche voted on patch set 2 CR +1 V +1 07/31/17, 08:23

  12. Susi Moog voted on patch set 2 CR +2 V +2 07/31/17, 08:27

  13. Gerrit merged patch set 2 07/31/17, 08:27

  14. Susi Moog commented on patch set 3 07/31/17, 08:27

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 769c6b0a2b18c74592a13e01fc6d848508ff0264