Review main Merged

53619[TASK] Refactor distribution list view with cards

Markus Sommer CR +2 V +2 Expert +704 −845 updated 09/08/17, 16:18

Commit message

The card component has been extended and is now more flexible to be
more usefull for different usecases, and is now used in the distribution
listing of the extension manager. We have also changed to Documentation
format of the CSS files to match KSS Knyle Style Sheets format.

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Christian Kuhn +1
  • Verified V +2
    • Benjamin Kott +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 17

Review log 2638

Show 813 earlier messages
  1. Markus Sommer uploaded patch set 1 07/28/17, 17:29

  2. Markus Sommer rebased onto patch set 2 07/28/17, 17:32

  3. TYPO3com voted on patch set 1 V +1 07/28/17, 17:41 Completed build in 11m 40s on Fri, 28 Jul, 07:41 PM Test Summary: 56916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13468

  4. TYPO3com voted on patch set 2 V +1 07/28/17, 17:43 Completed build in 10m 28s on Fri, 28 Jul, 07:43 PM Test Summary: 56916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13469

  5. Riccardo De Contardi voted on patch set 2 V +1 07/28/17, 18:58

  6. Jasmina Ließmann voted on patch set 2 CR +1 V +1 07/28/17, 22:13

  7. Henning Liebe commented on patch set 2 V -1 07/31/17, 09:57

    Label "Official Distribution" is missing. See Ticket for more details.
  8. Markus Sommer uploaded patch set 3 08/08/17, 15:16

  9. TYPO3com voted on patch set 3 V -1 08/08/17, 15:16 Completed build in 06s on Tue, 8 Aug, 05:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13592

  10. Markus Sommer uploaded patch set 4 08/11/17, 10:06

  11. Markus Sommer rebased onto patch set 5 08/11/17, 10:07

  12. TYPO3com voted on patch set 4 V +1 08/11/17, 10:18 Completed build in 11m 47s on Fri, 11 Aug, 12:18 PM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13644

  13. TYPO3com voted on patch set 5 V +1 08/11/17, 10:19 Completed build in 12m 01s on Fri, 11 Aug, 12:19 PM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13645

  1. Henning Liebe voted on patch set 5 V +1 08/14/17, 09:40

  2. Markus Sommer uploaded patch set 6 08/28/17, 07:31

  3. TYPO3com voted on patch set 6 V +1 08/28/17, 07:45 Completed build in 14m 02s on Mon, 28 Aug, 09:45 AM Test Summary: 58019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14047

  4. Sidoine Ghomsi Nokam commented on patch set 6 CR -1 08/28/17, 08:20

    _module_extensionmanager.scss:112

    just write one declaration of margin e.g. margin: 0 0 15px;
  5. Markus Sommer uploaded patch set 7 08/28/17, 08:26

  6. Markus Sommer commented on patch set 6 08/28/17, 08:27

    _module_extensionmanager.scss:112 Reply

    Resolved in next 7
  7. Sidoine Ghomsi Nokam voted on patch set 7 CR +1 08/28/17, 08:38

  8. Jörg Bösche voted on patch set 7 CR +1 V +1 08/28/17, 08:44

  9. TYPO3com voted on patch set 7 V -1 08/28/17, 09:24 Completed build in 57m 41s on Mon, 28 Aug, 11:24 AM Test Summary: 128 of 58382 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14048

  10. TYPO3com voted on patch set 7 V +1 08/28/17, 09:44 Completed build in 2h 15m 30s on Mon, 28 Aug, 11:44 AM Test Summary: 58019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14048

  11. Benjamin Kott commented on patch set 7 CR -2 09/07/17, 12:29

    i am on it
  12. Benjamin Kott uploaded patch set 8 09/08/17, 12:39

  13. TYPO3com voted on patch set 8 V -1 09/08/17, 12:39 Completed build in 08s on Fri, 8 Sep, 02:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14472

  14. Benjamin Kott uploaded patch set 9 09/08/17, 12:45

  15. Benjamin Kott uploaded patch set 10 09/08/17, 12:58

  16. Benjamin Kott voted on patch set 10 CR +1 V +1 09/08/17, 12:59

  17. TYPO3com voted on patch set 9 V +1 09/08/17, 13:04 Completed build in 18m 31s on Fri, 8 Sep, 03:04 PM Test Summary: 56821 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14479

  18. TYPO3com voted on patch set 10 V +1 09/08/17, 13:26 Completed build in 27m 07s on Fri, 8 Sep, 03:26 PM Test Summary: 56821 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14486

  19. Christian Kuhn commented on patch set 10 CR -1 09/08/17, 15:13

    great except the VH which could be kicked directly.

    Show.html:11

    this VH seems to be unused now and could be removed.
  20. Christian Kuhn commented on patch set 10 V -1 09/08/17, 15:16

    this re-introduces the bug fixed by markus with https://review.typo3.org/#/c/54005/3
  21. Benjamin Kott uploaded patch set 11 09/08/17, 15:40

  22. Christian Kuhn voted on patch set 11 CR +1 V +1 09/08/17, 15:55

  23. TYPO3com voted on patch set 11 V +1 09/08/17, 16:07 Completed build in 26m 54s on Fri, 8 Sep, 06:07 PM Test Summary: 56821 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14548

  24. Benjamin Kott voted on patch set 11 CR +2 V +2 09/08/17, 16:18

  25. Gerrit merged patch set 11 09/08/17, 16:18