Review main Abandoned Breaking

53630[WIP][!!!][TASK] Example on how to enforce protected/private

Benni Mack CR 0 V 0 Hard +186 −103 updated 09/10/17, 12:22

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 4

Review log 34

  1. Benni Mack uploaded patch set 1 07/31/17, 11:38

  2. TYPO3com voted on patch set 1 V -1 07/31/17, 11:48 Completed build in 10m 01s on Mon, 31 Jul, 01:48 PM Test Summary: 2187 of 57292 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13509

  3. Claus Due commented on patch set 1 07/31/17, 13:43

    I don't know if these are just examples to demonstrate, or the actual properties/methods you intend to make not-public? If these are the ones you are considering, I think we need to be a LOT less eager to replace public with protected. For example, several of the properties on TSFE make sense to manipulate via hooks which receive an instance of TSFE - and would have no public API to do so if the visibility was changed. Then there are methods on PageRepository which I for one have used in projects - it has to noted here that those methods work differently from the ones on BackendUtility and most definitely, the BackendUtility ones do not apply *especially* when you're doing FE previews. In short, much of this is API with a purpose and these are major breaking changes with no immediate migration possible ;)
  4. Benni Mack abandoned the change 09/10/17, 12:22