Review main Abandoned

53641[WIP][FEATURE] Allow environment variables in LocalConfig

Helmut Hummel CR 0 V 0 Normal +190 −46 updated 09/03/18, 11:29

Commit message

Adding helhum/config-loader as a dependency which allows to get the
global array $TYPO3_CONF_VARS from several places, and adds functionality
for placeholders:

%env(ENV_VAR)%
%const(CONSTANT)%

These variables can then be written within the Install Tool to write ENV variables
or constants to the system.

Additionally, the result of DefaultConfiguration and LocalConfiguration are now
cached within "typo3temp/var/Cache/Code/" and are loaded faster than before
(due to the CachedConfigurationLoader).

ToDo:
- Drop unnecessary options within ConfigurationManager
- Check test cases for broken instances etc.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 1323

  1. Helmut Hummel uploaded patch set 1 08/03/17, 00:06

  2. Helmut Hummel uploaded patch set 2 08/03/17, 00:11

  3. Benni Mack uploaded patch set 3 08/14/17, 20:03

  4. TYPO3com voted on patch set 3 V -1 08/14/17, 20:05 Completed build in 02m 05s on Mon, 14 Aug, 10:05 PM Test Summary: 3509 of 3584 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13707

  5. Benni Mack commented on patch set 3 08/14/17, 20:05

    @helhum we might need to add the option to enter a placeholder value in the install tool as done here: https://review.typo3.org/#/c/53639/ to make it max. flexible for the install tool. Same would be nice for the StepInstaller when entering DB credentials. What do you think?
  6. Benni Mack uploaded patch set 4 08/28/17, 10:11

  7. TYPO3com voted on patch set 4 V -1 08/28/17, 10:13 Completed build in 01m 52s on Mon, 28 Aug, 12:13 PM Test Summary: 3959 of 4032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14053

  8. Benni Mack uploaded patch set 5 09/06/17, 05:36

  9. TYPO3com voted on patch set 5 V -1 09/06/17, 05:38 Completed build in 02m 14s on Wed, 6 Sep, 07:38 AM Test Summary: 3959 of 4032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14245

  10. Simon Praetorius uploaded patch set 6 09/08/17, 12:49

  11. TYPO3com voted on patch set 6 V -1 09/08/17, 12:59 Completed build in 09m 56s on Fri, 8 Sep, 02:59 PM Test Summary: 2645 of 2718 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14484

  12. Simon Praetorius uploaded patch set 7 09/08/17, 14:01

  13. TYPO3com voted on patch set 7 V -1 09/08/17, 14:06 Completed build in 04m 55s on Fri, 8 Sep, 04:06 PM Test Summary: 2643 of 57108 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14513

  14. TYPO3com commented on patch set 7 09/08/17, 14:29 Completed build in 33m 05s on Fri, 8 Sep, 04:29 PM Test Summary: 2643 of 57108 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14513

  15. Simon Praetorius uploaded patch set 8 09/08/17, 14:42

  16. TYPO3com voted on patch set 8 V -1 09/08/17, 14:44 Completed build in 02m 11s on Fri, 8 Sep, 04:44 PM Test Summary: 2643 of 57108 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14524

  17. Simon Praetorius uploaded patch set 9 09/10/17, 09:32

  18. TYPO3com voted on patch set 9 V -1 09/10/17, 09:34 Completed build in 02m 24s on Sun, 10 Sep, 11:34 AM Test Summary: 3990 of 58431 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14792

  19. Simon Praetorius uploaded patch set 10 09/10/17, 10:22

  20. TYPO3com voted on patch set 10 V -1 09/10/17, 10:25 Completed build in 02m 33s on Sun, 10 Sep, 12:25 PM Test Summary: 3990 of 58431 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14803

  21. Benni Mack uploaded patch set 11 10/02/17, 12:01

  22. TYPO3com voted on patch set 11 V -1 10/02/17, 12:03 Completed build in 02m 08s on Mon, 2 Oct, 02:03 PM Test Summary: 2748 of 57051 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15264

  23. Helmut Hummel abandoned the change 09/03/18, 11:29