Review main Merged

53646[BUGFIX] New values created by AddController are added correctly

Andreas Kienast CR +2 V +2 Easy +14 −6 updated 08/09/17, 08:05

Commit message

New values created by AddController are now added again to the FlexForm
value by fixing the value parsing.

Additionally, the mixed up append/prepend values of `setValue` are fixed.

Review

  • Code review CR +2
    • Susi Moog +2
    • Markus Klein +1
    • Sebastian Fischer +1
    • Jörg Bösche +1
  • Verified V +2
    • Susi Moog +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1012

  1. Andreas Kienast uploaded patch set 1 08/04/17, 14:55

  2. TYPO3com voted on patch set 1 V +1 08/04/17, 15:06 Completed build in 10m 52s on Fri, 4 Aug, 05:06 PM Test Summary: 57414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13569

  3. Andreas Kienast uploaded patch set 2 08/07/17, 07:26

  4. Andreas Kienast commented on patch set 2 08/07/17, 07:26

    A test extension has been added to #82049
  5. TYPO3com voted on patch set 2 V +1 08/07/17, 07:36 Completed build in 09m 58s on Mon, 7 Aug, 09:36 AM Test Summary: 57414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13578

  6. Sebastian Fischer voted on patch set 2 CR +1 08/07/17, 07:38

  7. Susi Moog voted on patch set 2 CR +1 V +1 08/08/17, 07:00

  8. Markus Klein voted on patch set 2 CR +1 08/08/17, 08:41

  9. Jörg Bösche commented on patch set 2 CR +1 V +1 08/09/17, 08:03

    Verified on master (T3 v9)
  10. Susi Moog voted on patch set 2 CR +2 V +2 08/09/17, 08:04

  11. Gerrit merged patch set 2 08/09/17, 08:04

  12. Susi Moog commented on patch set 3 08/09/17, 08:05

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ee94ab9aba26b6816622bea14660c72a9de6e5ab