Review main Merged

53648[BUGFIX] Filter http/verify option for guzzle to boolean

Wolfgang Klinger CR +2 V +2 Easy +4 −1 updated 08/14/17, 18:53

Commit message

guzzle expects a real boolean value.
This fix filters the given verify option to either the boolean
equivalent or leaves any other string (path to certificate) as is.

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Sommer +1
    • Jan Helke +1
    • Henning Liebe +1
    • Andreas Kienast +1
    • Jörg Bösche +1
    • Steffen Frese +1
  • Verified V +2
    • Benni Mack +2
    • Henning Liebe +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Wolfgang Klinger uploaded patch set 1 08/07/17, 06:34

  2. Wolfgang Klinger updated the commit message in patch set 2 08/07/17, 06:37

  3. TYPO3com voted on patch set 1 V +1 08/07/17, 06:46 Completed build in 11m 10s on Mon, 7 Aug, 08:46 AM Test Summary: 57414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13576

  4. TYPO3com voted on patch set 2 V +1 08/07/17, 06:48 Completed build in 11m 20s on Mon, 7 Aug, 08:48 AM Test Summary: 57414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13577

  5. Jörg Bösche commented on patch set 2 CR +1 V +1 08/07/17, 09:17

    Looks good to me, but this is a general issue in our InstallTool. In this case it is okay to validate the argument.
  6. Andreas Kienast voted on patch set 2 CR +1 08/11/17, 08:42

  7. Jan Helke voted on patch set 2 CR +1 08/11/17, 10:05

  8. Markus Sommer voted on patch set 2 CR +1 08/11/17, 10:21

  9. Henning Liebe voted on patch set 2 CR +1 V +1 08/14/17, 08:37

  10. Steffen Frese voted on patch set 2 CR +1 08/14/17, 09:48

  11. Benni Mack voted on patch set 2 CR +2 V +2 08/14/17, 18:53

  12. Gerrit merged patch set 2 08/14/17, 18:53

  13. Benni Mack commented on patch set 3 08/14/17, 18:53

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 86cd2138b32158e03a12d567865637782624b2b4