53650[BUGFIX] YouTubeRenderer "controls" option
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Frank Nägler +1
-
Verified V +2
- Andreas Kienast +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 3240
Show 1215 earlier messages
-
Česlav Przywara uploaded patch set 1 08/07/17, 09:50
-
TYPO3com voted on patch set 1 V -1 08/07/17, 10:01 Completed build in 10m 20s on Mon, 7 Aug, 12:01 PM Test Summary: 6 of 57784 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13580
-
Česlav Przywara commented on patch set 1 08/07/17, 10:35
> Completed build in 10m 20s on Mon, 7 Aug, 12:01 PM > Test Summary: 6 of 57784 failed > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13580 It seems the tests need to be fixed as well... -
Česlav Przywara uploaded patch set 2 08/07/17, 10:46
-
TYPO3com voted on patch set 2 V +1 08/07/17, 10:56 Completed build in 09m 51s on Mon, 7 Aug, 12:56 PM Test Summary: 57420 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13581
-
Wolfgang Klinger voted on patch set 2 CR +1 V +1 08/09/17, 07:13
-
Wouter Wolters voted on patch set 2 CR +1 08/09/17, 07:17
-
Andreas Kienast commented on patch set 2 CR -1 08/09/17, 13:14
YouTubeRenderer.php:109This allows _any_ integer value for `controls`, which is IMO incorrect. -
Wolfgang Klinger commented on patch set 2 08/09/17, 13:27
YouTubeRenderer.php:109ReplyI thought about that too, but makes no sense at this place. Youtube handles this (the video still works if you supply some nonsense). -
Sascha Rademacher voted on patch set 2 CR +1 V +1 08/14/17, 08:33
-
Andreas Kienast voted on patch set 2 CR +1 08/15/17, 06:31
-
Andreas Kienast uploaded patch set 3 08/15/17, 06:39
-
Andreas Kienast voted on patch set 3 CR +1 V +1 08/15/17, 06:39
-
Andreas Kienast commented on patch set 3 08/15/17, 06:39
I've removed 7.6 from Releases line as this is no priority bugfix. -
TYPO3com voted on patch set 3 V +1 08/15/17, 06:48 Completed build in 09m 38s on Tue, 15 Aug, 08:48 AM Test Summary: 57444 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13712
-
Frank Nägler voted on patch set 3 CR +1 08/15/17, 11:41
-
Frank Nägler commented on patch set 3 CR -1 08/15/17, 11:53
on it -
Frank Nägler uploaded patch set 4 08/15/17, 13:06
-
TYPO3com voted on patch set 4 V -1 08/15/17, 13:06 Completed build in 10s on Tue, 15 Aug, 03:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13725
-
Frank Nägler commented on patch set 4 CR +1 V +1 08/15/17, 13:07
I have added some more test cases, and refactored the code which check the input. The controls parameter allows three values: 0,1 and 2 only this values are allowed yet. Other values will be forced to 2, which is the old default. -
Frank Nägler uploaded patch set 5 08/15/17, 13:09
-
Frank Nägler voted on patch set 5 CR +1 V +1 08/15/17, 13:10
-
Andreas Kienast commented on patch set 5 08/15/17, 13:10
YouTubeRenderer.php:111If larger than 3, then 2? :) -
Frank Nägler uploaded patch set 6 08/15/17, 13:12
-
Frank Nägler commented on patch set 5 08/15/17, 13:12
YouTubeRenderer.php:111Replythx, fixed -
Frank Nägler voted on patch set 6 CR +1 V +1 08/15/17, 13:13
-
Andreas Kienast commented on patch set 6 CR -1 08/15/17, 13:21
on it -
Andreas Kienast uploaded patch set 7 08/15/17, 13:21
-
Andreas Kienast voted on patch set 7 CR +1 V +1 08/15/17, 13:22
-
Wouter Wolters commented on patch set 7 CR -1 08/15/17, 13:25
we had this discussion before but we call phpunit with $this and not with self:: or static:: This question was previously raised by Oliver Klee and he asked the author op phpunit to clarify. PHPstorm is in the wrong here according to the author. IMHO please use $this again. -
TYPO3com voted on patch set 5 V +1 08/15/17, 13:27 Completed build in 17m 51s on Tue, 15 Aug, 03:27 PM Test Summary: 57509 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13729
-
TYPO3com voted on patch set 6 V +1 08/15/17, 13:30 Completed build in 18m 05s on Tue, 15 Aug, 03:30 PM Test Summary: 57521 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13730
-
Frank Nägler uploaded patch set 8 08/15/17, 13:31
-
Frank Nägler voted on patch set 8 CR +1 V +1 08/15/17, 13:32
-
TYPO3com voted on patch set 7 V +1 08/15/17, 13:36 Completed build in 14m 49s on Tue, 15 Aug, 03:36 PM Test Summary: 57533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13732
-
Andreas Kienast voted on patch set 8 CR +2 V +1 08/15/17, 13:38
-
TYPO3com voted on patch set 8 V +1 08/15/17, 13:42 Completed build in 10m 48s on Tue, 15 Aug, 03:42 PM Test Summary: 57533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13733
-
Andreas Kienast voted on patch set 8 V +2 08/15/17, 13:42
-
Gerrit merged patch set 8 08/15/17, 13:42
-
Andreas Kienast commented on patch set 9 08/15/17, 13:43
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 739adb90e56eab87a5f3986bbc02ff6abb49afac