Review main Merged

53651[BUGFIX] Let all toplevel exceptions extend the core exception

Mathias Brodala CR +2 V +2 Normal +111 −15 updated 08/11/17, 08:41

Commit message

This is a small step to unify exception handling in TYPO3 by
ensuring no internal and 3rd party code is forced to catch the
toplevel PHP exception.

This change e.g. actually allows the FormPagePreviewRenderer to
handle form loading errors.

Review

  • Code review CR +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Wolfgang Klinger +1
    • Jörg Bösche +1
  • Verified V +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 1214

  1. Mathias Brodala uploaded patch set 1 08/07/17, 10:51

  2. TYPO3com voted on patch set 1 V +1 08/07/17, 11:02 Completed build in 10m 35s on Mon, 7 Aug, 01:02 PM Test Summary: 57420 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13582

  3. Sascha Egerer voted on patch set 1 CR +1 08/09/17, 05:43

  4. Wolfgang Klinger voted on patch set 1 CR +1 08/09/17, 06:52

  5. Mathias Brodala commented on patch set 1 CR -1 08/09/17, 12:18

    This change will be extended to do the same fix for all system extensions.
  6. Mathias Brodala uploaded patch set 2 08/09/17, 12:42

  7. Wolfgang Klinger voted on patch set 2 CR +1 08/09/17, 12:45

  8. TYPO3com voted on patch set 2 V +1 08/09/17, 12:52 Completed build in 09m 40s on Wed, 9 Aug, 02:52 PM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13605

  9. Susi Moog voted on patch set 2 CR +1 V +1 08/10/17, 09:59

  10. Mathias Schreiber voted on patch set 2 CR +1 V +1 08/10/17, 10:02

  11. Jörg Bösche voted on patch set 2 CR +1 V +1 08/11/17, 08:14

  12. Susi Moog voted on patch set 2 CR +2 V +2 08/11/17, 08:40

  13. Gerrit merged patch set 2 08/11/17, 08:40

  14. Susi Moog commented on patch set 3 08/11/17, 08:41

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 491798356cfcba618803a8c28a5450b21c38faf3