Review TYPO3_8-7 Merged

53655[BUGFIX] Do not detect single select fields as relation

Georg Ringer CR +2 V +2 Easy +32 −1 updated 08/08/17, 05:19

Commit message

With https://review.typo3.org/50879/ all TCA select fields
are detected as relation to many, even when they are configured
as simple static select.

This leads to the row value to be pre-set as string (to hold comma
separated values), which leads to an exception in MySQL Strict Mode
when the select value field is defined as integer.

Therefore only detect renderType === selectMultipleSideBySide
as relational field

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 2

Review log 34

  1. Georg Ringer commented on patch set 1 08/08/17, 05:07

    Cherry Picked from branch master.
  2. Georg Ringer voted on patch set 1 CR +2 V +2 08/08/17, 05:07

  3. Gerrit merged patch set 1 08/08/17, 05:07

  4. TYPO3com commented on patch set 1 08/08/17, 05:19 Completed build in 11m 57s on Tue, 8 Aug, 07:19 AM Test Summary: 58383 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-658