Review main Merged

53664[BUGFIX] Implode array values in SaveToDatabaseFinisher

Andreas Kienast CR +2 V +2 Normal +64 −24 updated 08/15/17, 11:26

Commit message

Array values being processed by SaveToDatabaseFinisher are now
imploded by a comma. This may happen when using a `MultiCheckbox` element.

Review

  • Code review CR +2
    • Susi Moog +2
    • Jörg Bösche +1
  • Verified V +2
    • Susi Moog +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1215

  1. Andreas Kienast uploaded patch set 1 08/09/17, 10:11

  2. TYPO3com voted on patch set 1 V -1 08/09/17, 10:11 Completed build in 09s on Wed, 9 Aug, 12:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13600

  3. Andreas Kienast uploaded patch set 2 08/09/17, 10:13

  4. TYPO3com voted on patch set 2 V +1 08/09/17, 10:24 Completed build in 11m 10s on Wed, 9 Aug, 12:24 PM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13601

  5. Mathias Brodala commented on patch set 2 CR +1 08/09/17, 10:26

    I guess this does the trick for now but in the middle/long term we'll most likely need stdWrap for element values.
  6. Normen Möller voted on patch set 2 CR +1 V +1 08/09/17, 12:00

  7. Jörg Bösche voted on patch set 2 CR +1 08/11/17, 08:15

  8. Jan Helke voted on patch set 2 CR +1 08/11/17, 11:01

  9. Susi Moog uploaded patch set 3 08/14/17, 08:30

  10. TYPO3com voted on patch set 3 V +1 08/14/17, 08:43 Completed build in 12m 18s on Mon, 14 Aug, 10:43 AM Test Summary: 57438 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13672

  11. Susi Moog voted on patch set 3 CR +1 V +1 08/14/17, 08:46

  12. Jörg Bösche voted on patch set 3 CR +1 V +1 08/15/17, 11:12

  13. Susi Moog voted on patch set 3 CR +2 V +2 08/15/17, 11:25

  14. Gerrit merged patch set 3 08/15/17, 11:25

  15. Susi Moog commented on patch set 4 08/15/17, 11:26

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 9fa46902f89139715fb5e8d53b74fd2c5313c22a