Review main Abandoned

53668[BUGFIX] Check TSFE->gr_list before using explode

Wolfgang Klinger CR 0 V 0 Easy +2 −1 updated 08/09/17, 18:24

Commit message

This prevents a fatal error, when TSFE->gr_list is null

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 45

  1. Wolfgang Klinger uploaded patch set 1 08/09/17, 16:25

  2. TYPO3com voted on patch set 1 V +1 08/09/17, 16:36 Completed build in 11m 03s on Wed, 9 Aug, 06:36 PM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13618

  3. Wouter Wolters commented on patch set 1 CR -2 08/09/17, 17:07

    On hold, tried this change before but that was not accepted. Will look for details later this evening.
  4. Wouter Wolters commented on patch set 1 08/09/17, 18:22

    https://review.typo3.org/#/c/49704/ the original change. The revert https://review.typo3.org/#/c/49719/ So IMO the error must me solved in the code where the restriction is used wrongly.
  5. Wolfgang Klinger abandoned the change 08/09/17, 18:24

    Abandoned