Review main Merged

53674[BUGFIX] Add sorting to group by for SQL compatibility

Susi Moog CR +2 V +2 Easy +4 −3 updated 08/11/17, 09:19

Commit message

Page module, view module and edit document selected data
with an incomplete group by statement, missing the sorting
column. This resulted in an error on mssql servers.

The sorting field was added to the relevant queries.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 67

  1. Susi Moog uploaded patch set 1 08/11/17, 08:19

  2. TYPO3com voted on patch set 1 V +1 08/11/17, 08:30 Completed build in 10m 21s on Fri, 11 Aug, 10:30 AM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13637

  3. Jörg Bösche commented on patch set 1 CR +1 V +1 08/11/17, 09:05

    Verified on MySQL 5.7.19 with `only_full_group_by` directive. Still works without problems.
  4. Christian Kuhn voted on patch set 1 CR +1 V +1 08/11/17, 09:15

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 08/11/17, 09:19

  6. Gerrit merged patch set 1 08/11/17, 09:19

  7. Andreas Kienast commented on patch set 2 08/11/17, 09:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit a81757c32bc47617c201c11a66fd33d8b2ffac8d