Review TYPO3_8-7 Merged

53676[BUGFIX] Add sorting to group by for SQL compatibility

Andreas Kienast CR +2 V +2 Easy +4 −3 updated 08/11/17, 09:31

Commit message

Page module, view module and edit document selected data
with an incomplete group by statement, missing the sorting
column. This resulted in an error on mssql servers.

The sorting field was added to the relevant queries.

Review

  • Code review CR +2
    • Andreas Kienast +2
  • Verified V +2
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Andreas Kienast commented on patch set 1 08/11/17, 09:19

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 08/11/17, 09:30 Completed build in 11m 06s on Fri, 11 Aug, 11:30 AM Test Summary: 58383 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-672

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 08/11/17, 09:31

  4. Gerrit merged patch set 1 08/11/17, 09:31