Review main Merged

53677[BUGFIX] Drop sorting in COUNT() query in list module

Susi Moog CR +2 V +2 Easy +13 −9 updated 08/11/17, 10:59

Commit message

The list module throws an exception on mssql as there
is a COUNT(*) query done with an ORDER BY sorting.

Sorting the count is pretty useless and has been
removed.

Review

  • Code review CR +2
    • Susi Moog +2
    • Wouter Wolters +1
    • Jan Helke +1
    • Christian Kuhn +1
  • Verified V +2
    • Susi Moog +2
    • Jan Helke +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Susi Moog uploaded patch set 1 08/11/17, 09:30

  2. Wouter Wolters voted on patch set 1 CR +1 08/11/17, 09:35

  3. Christian Kuhn voted on patch set 1 CR +1 08/11/17, 09:38

  4. TYPO3com voted on patch set 1 V -1 08/11/17, 09:44 Completed build in 14m 11s on Fri, 11 Aug, 11:44 AM Test Summary: 1 of 57796 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13641

  5. TYPO3com voted on patch set 1 V +1 08/11/17, 09:51 Completed build in 34m 54s on Fri, 11 Aug, 11:51 AM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13641

  6. Jan Helke voted on patch set 1 CR +1 V +1 08/11/17, 10:04

  7. Christian Kuhn voted on patch set 1 V +1 08/11/17, 10:45

  8. Susi Moog voted on patch set 1 CR +2 V +2 08/11/17, 10:59

  9. Gerrit merged patch set 1 08/11/17, 10:59