Review TYPO3_7-6 Merged

53684[BUGFIX] Use DriverInterface instead AbstractDriver for method signature

Franz Koch CR +2 V +2 Easy +3 −3 updated 08/18/17, 07:54

Commit message

FAL drivers are not obligated to extend the AbstractDriver but only
to implement the DriverInterface. Having custom drivers that are not
based on AbstractDriver (because they are f.e. non hierarchical)
currently causes an Exception because PreviewProcessing expects an
instance of AbstractDriver as method argument.

This patch changes te signature from AbstractDriver to DriverInterface.

Review

  • Code review CR +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1319

  1. Franz Koch uploaded patch set 1 08/12/17, 08:57

  2. TYPO3com voted on patch set 1 V +1 08/12/17, 09:03 Completed build in 06m 12s on Sat, 12 Aug, 11:03 AM Test Summary: 38848 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1052

  3. Franz Koch updated the commit message in patch set 2 08/12/17, 09:04

  4. TYPO3com voted on patch set 2 V +1 08/12/17, 09:10 Completed build in 05m 39s on Sat, 12 Aug, 11:10 AM Test Summary: 38848 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1053

  5. Wouter Wolters commented on patch set 2 CR -1 08/12/17, 16:05

    missing Releases tag in the commit message. Does this bug also occurs in master or 8.7?
  6. Franz Koch commented on patch set 2 08/12/17, 18:05

    Releases tag is there, isn't it? As for master or 8.7. I just had a look at those repositories, and yes, they seem to have the same issue (referencing AbstractDriver instead of DriverInterface). I'll update the Releases tag in the commit message
  7. Franz Koch updated the commit message in patch set 3 08/12/17, 18:08

  8. TYPO3com voted on patch set 3 V +1 08/12/17, 18:14 Completed build in 06m 32s on Sat, 12 Aug, 08:14 PM Test Summary: 38848 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1054

  9. Frans Saris commented on patch set 3 08/15/17, 12:41

    Hi Franz, could you create a ticket on forge for this and reference it in the commit message?
  10. Andreas Kienast commented on patch set 3 08/15/17, 12:43

    Please push this change to the master branch first. After merging, the change gets backported to the desired branches.
  11. Wolfgang Klinger commented on patch set 3 CR +1 08/16/17, 12:20

    change looks good, but see all the other replies first
  12. Franz Koch commented on patch set 3 08/16/17, 12:36

    created a ticket and pushed it to master
  13. Susi Moog uploaded patch set 4 08/18/17, 05:55

  14. TYPO3com voted on patch set 4 V -1 08/18/17, 06:03 Completed build in 07m 08s on Fri, 18 Aug, 08:03 AM Test Summary: 2 of 38912 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1064

  15. TYPO3com voted on patch set 4 V +1 08/18/17, 06:09 Completed build in 20m 29s on Fri, 18 Aug, 08:09 AM Test Summary: 38912 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1064

  16. Susi Moog uploaded patch set 5 08/18/17, 07:13

  17. TYPO3com voted on patch set 5 V +1 08/18/17, 07:22 Completed build in 08m 49s on Fri, 18 Aug, 09:22 AM Test Summary: 38912 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1067

  18. Susi Moog voted on patch set 5 CR +2 V +2 08/18/17, 07:54

  19. Gerrit merged patch set 5 08/18/17, 07:54