Review main Merged

53685[FEATURE] Allow inline rendering for SVG content object

Frank Nägler CR +2 V +2 Normal +94 −27 updated 08/16/17, 08:30

Commit message

This patch add a new setting to allow inline rendering of SVG files.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Josef Glatz +1
    • Wouter Wolters +1
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2330

Show 35 earlier messages
  1. Frank Nägler uploaded patch set 1 08/12/17, 10:49

  2. Frank Nägler uploaded patch set 2 08/12/17, 10:52

  3. TYPO3com voted on patch set 2 V +1 08/12/17, 11:03 Completed build in 11m 06s on Sat, 12 Aug, 01:03 PM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13665

  4. TYPO3com voted on patch set 1 V -1 08/12/17, 11:33 Completed build in 43m 41s on Sat, 12 Aug, 01:33 PM Test Summary: 113 of 57796 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13664

  5. Christian Müllenhagen commented on patch set 2 CR -1 08/12/17, 11:45

    ScalableVectorGraphicsContentObject.php:46

    $conf seems to be an array. Please add the typehint.

    ScalableVectorGraphicsContentObject.php:50

    You could return here also return an empty string, as it will be done anyways in line 54 if src is null, right?
  1. Frank Nägler commented on patch set 2 08/12/17, 20:24

    ScalableVectorGraphicsContentObject.php:46 Reply

    nope, in case the render method is called without and array or NULL this would fatal and break.

    ScalableVectorGraphicsContentObject.php:50 Reply

    I think another return would not make the code better, the check in line 54 is required. If I read the code again, the lines 49-51 can be removed.
  2. Christian Müllenhagen commented on patch set 2 CR 0 08/13/17, 13:00

    ScalableVectorGraphicsContentObject.php:46 Reply

    But in the current implementation it will always be called with an array, right? So why not make it as strict as possible?

    ScalableVectorGraphicsContentObject.php:50 Reply

    Yes, could be removed. The only advantage would be to prevent the call of the 'file_exists' method.
  3. Philipp Gampe commented on patch set 2 08/13/17, 14:11

    Remove "This patch" ... Add a new setting ...

    Feature-82091-AllowInlineRenderingInSVGContentObject.rst:12

    remove the also

    Feature-82091-AllowInlineRenderingInSVGContentObject.rst:26

    remove also

    ScalableVectorGraphicsContentObject.php:26

    This was not even true before

    ScalableVectorGraphicsContentObject.php:28

    typehint

    ScalableVectorGraphicsContentObject.php:46 Reply

    It must be an array, because it must at least be an empty array. Unless I overlook something?

    ScalableVectorGraphicsContentObject.php:75

    typehint
  4. Frank Nägler commented on patch set 2 08/14/17, 10:25

    ScalableVectorGraphicsContentObject.php:28 Reply

    nope, this would be a breaking change. in case the method is called with a "null" value, this would brea with a type hint.

    ScalableVectorGraphicsContentObject.php:46 Reply

    can you ensure that the input in render() is never null?
  5. Frank Nägler uploaded patch set 3 08/14/17, 10:26

  6. TYPO3com voted on patch set 3 V +1 08/14/17, 10:36 Completed build in 10m 34s on Mon, 14 Aug, 12:36 PM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13684

  7. Georg Ringer commented on patch set 3 08/14/17, 10:43

    ScalableVectorGraphicsContentObject.php:42

    missing type
  8. Philipp Gampe commented on patch set 2 08/14/17, 15:13

    ScalableVectorGraphicsContentObject.php:28 Reply

    Should never happen, at least not with vanilla core. If this ever happens, it can be considered a bug and this SHOULD break.
  9. Philipp Gampe commented on patch set 3 08/14/17, 15:14

    ScalableVectorGraphicsContentObject.php:46

    See my comment in patchset 2, please add the type hint here.
  10. Frank Nägler commented on patch set 4 08/14/17, 17:58

    Published edit on patch set 3.
  11. Frank Nägler commented on patch set 3 08/14/17, 17:59

    ScalableVectorGraphicsContentObject.php:46 Reply

    please read my answer on your comment
  12. TYPO3com voted on patch set 4 V +1 08/14/17, 18:11 Completed build in 13m 00s on Mon, 14 Aug, 08:11 PM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13699

  13. Frank Nägler uploaded patch set 5 08/15/17, 09:22

  14. Frank Nägler commented on patch set 5 08/15/17, 09:26

    After a lot of discussions, I have now added the type hint for the new protected methods, but not for the main render method, because the methods must be compatible with the definition in the AbstractContentObject. Anyway, In the case that it breaks, I have previously pointed out clearly.
  15. Andreas Kienast voted on patch set 5 CR +1 08/15/17, 09:38

  16. TYPO3com voted on patch set 5 V -1 08/15/17, 09:46 Completed build in 23m 58s on Tue, 15 Aug, 11:46 AM Test Summary: 1 of 57796 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13718

  17. TYPO3com voted on patch set 5 V +1 08/15/17, 09:50 Completed build in 52m 45s on Tue, 15 Aug, 11:50 AM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13718

  18. Andreas Kienast updated the commit message in patch set 6 08/15/17, 11:31

  19. Andreas Kienast voted on patch set 6 CR +1 V +1 08/15/17, 11:31

  20. TYPO3com voted on patch set 6 V +1 08/15/17, 11:45 Completed build in 14m 12s on Tue, 15 Aug, 01:45 PM Test Summary: 57438 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13721

  21. Wouter Wolters voted on patch set 6 CR +1 08/15/17, 13:22

  22. Josef Glatz voted on patch set 6 CR +1 08/16/17, 06:02

  23. Jörg Bösche voted on patch set 6 CR +1 V +1 08/16/17, 07:35

  24. Andreas Kienast voted on patch set 6 CR +2 V +2 08/16/17, 08:30

  25. Gerrit merged patch set 6 08/16/17, 08:30