Review main Merged

53687[BUGFIX] Use the real page id for doesPageHaveUnallowedTables check

Wolfgang Klinger CR +2 V +2 Easy +3 −1 updated 03/07/18, 14:37

Commit message

In case of handling a translated page record, use the according
proper uid value of the containing page of default language.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2
    • Oliver Hader +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1822

  1. Wolfgang Klinger uploaded patch set 1 08/12/17, 18:53

  2. TYPO3com voted on patch set 1 V -1 08/12/17, 19:42 Completed build in 48m 56s on Sat, 12 Aug, 09:42 PM Test Summary: 119 of 57796 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13668

  3. Wolfgang Klinger updated the commit message in patch set 2 08/13/17, 10:03

  4. TYPO3com voted on patch set 2 V +1 08/13/17, 10:12 Completed build in 09m 14s on Sun, 13 Aug, 12:12 PM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13669

  5. Philipp Gampe commented on patch set 2 CR +1 08/13/17, 14:13

    A test would be nice though.
  6. Sonja Großewinkelmann voted on patch set 2 CR +1 08/14/17, 07:50

  7. Henning Liebe voted on patch set 2 CR +1 08/14/17, 08:05

  8. Tobi Kretschmann voted on patch set 2 CR +1 08/14/17, 10:20

  9. Jörg Bösche voted on patch set 2 CR +1 09/04/17, 06:57

  10. Benni Mack voted on patch set 2 CR +2 10/03/17, 20:04

  11. Jigal van Hemert commented on patch set 2 11/01/17, 13:25

    Once https://forge.typo3.org/issues/82445 is merged this patch is not relevant anymore for master.
  12. Jigal van Hemert commented on patch set 2 11/17/17, 09:43

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 0c1df8c3c979f24a7ed534a12ae05db883171184
  13. Jigal van Hemert abandoned the change 11/17/17, 09:45

    With the removal of pages_language_overlay this patch is not relevant for master any more. It's ported to the 8.7 branch and this patch for master is therefore abandoned.
  14. Oliver Hader restored the change 03/07/18, 13:31

  15. Oliver Hader uploaded patch set 3 03/07/18, 13:31

  16. Oliver Hader updated the commit message in patch set 4 03/07/18, 13:32

  17. TYPO3com voted on patch set 3 V +1 03/07/18, 13:40 Completed build in 09m 16s on Wed, 7 Mar, 02:40 PM Test Summary: 30812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20630

  18. TYPO3com voted on patch set 4 V +1 03/07/18, 13:43 Completed build in 10m 49s on Wed, 7 Mar, 02:43 PM Test Summary: 30812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20631

  19. Oliver Hader voted on patch set 4 V +1 CR +1 03/07/18, 14:04

  20. Benni Mack voted on patch set 4 V +1 CR +1 03/07/18, 14:35

  21. Oliver Hader voted on patch set 4 V +2 CR +2 03/07/18, 14:37

  22. Oliver Hader merged patch set 5 03/07/18, 14:37