Review main Merged

53701[BUGFIX] _LOCAL_LANG overwrite via TypoScript with nested keys

Susi Moog CR +2 V +2 Easy +7 −1 updated 08/15/17, 11:00

Commit message

If language labels are set for the top level key and sub
keys in TypoScript the top level key was not taken into
account as it got stored with 'typoScriptNodeValue' as key.

Special handling for that specific key was introduced, to
make overwriting of top level keys possible again.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Susi Moog uploaded patch set 1 08/15/17, 07:45

  2. TYPO3com voted on patch set 1 V -1 08/15/17, 07:56 Completed build in 11m 13s on Tue, 15 Aug, 09:56 AM Test Summary: 1 of 57796 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13716

  3. TYPO3com voted on patch set 1 V +1 08/15/17, 08:23 Completed build in 49m 23s on Tue, 15 Aug, 10:23 AM Test Summary: 57432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13716

  4. Jörg Bösche commented on patch set 1 CR +1 V +1 08/15/17, 08:26

    Verified on version 8.7 and master (9-dev)
  5. Andreas Kienast voted on patch set 1 CR +2 V +1 08/15/17, 10:59

  6. Andreas Kienast voted on patch set 1 V +2 08/15/17, 11:00

  7. Gerrit merged patch set 1 08/15/17, 11:00

  8. Andreas Kienast commented on patch set 2 08/15/17, 11:00

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ddf4e1a02de27d66150d36ca43ccd3c0b915c409