Review TYPO3_8-7 Merged

53708[BUGFIX] YouTubeRenderer "controls" option

Andreas Kienast CR +2 V +2 Normal +92 −19 updated 08/15/17, 13:55

Commit message

The "controls" parameter appended to YouTube embed URL is either set to
value provided in $options array or to default backwards-compatible
value (controls=2).

Specifically, if controls option is set to 0, the controls parameter
must be present in URL, because default value for it is 1.

Fix is applied to related unit test too.

Review

  • Code review CR +2
    • Andreas Kienast +2
  • Verified V +2
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 08/15/17, 13:43

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 08/15/17, 13:53 Completed build in 10m 44s on Tue, 15 Aug, 03:53 PM Test Summary: 58479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-700

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 08/15/17, 13:55

  4. Gerrit merged patch set 1 08/15/17, 13:55