53710[BUGFIX] Fix SQL error when bookmarking a sys_file_metadata record
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Sascha Egerer +1
- Andreas Kienast +1
-
Verified V +2
- Christian Kuhn +2
- Sascha Egerer +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1316
-
Wouter Wolters uploaded patch set 1 08/15/17, 18:06
-
TYPO3com voted on patch set 1 V +1 08/15/17, 18:17 Completed build in 11m 00s on Tue, 15 Aug, 08:17 PM Test Summary: 57533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13740
-
Oliver Hader updated the commit message in patch set 2 08/15/17, 18:20
-
Oliver Hader voted on patch set 2 V +1 08/15/17, 18:23
-
TYPO3com voted on patch set 2 V +1 08/15/17, 18:31 Completed build in 11m 11s on Tue, 15 Aug, 08:31 PM Test Summary: 57533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13741
-
Sascha Egerer commented on patch set 2 CR -1 08/15/17, 20:05
Instead of checking for that explicit table we should check for a colon in the fieldname. This is a feature of TCA and may also appear in other tables. -
Wolfgang Klinger commented on patch set 2 08/16/17, 12:13
I checked the used methods iconFactory->getIconForRecord and others and I see no usage of 'type' at all (they use 'typeicon_column'), so I would suggest to check that again thoroughly ;-) and then remove the $GLOBALS['TCA'][$table]['ctrl']['type'] lines altogether -
Wouter Wolters uploaded patch set 3 08/17/17, 12:15
-
TYPO3com voted on patch set 3 V +1 08/17/17, 12:25 Completed build in 10m 01s on Thu, 17 Aug, 02:25 PM Test Summary: 57533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-13779
-
Andreas Kienast voted on patch set 3 CR +1 08/17/17, 13:33
-
Andreas Kienast voted on patch set 3 V +1 08/18/17, 13:38
-
Sascha Egerer voted on patch set 3 CR +1 V +1 08/19/17, 18:56
-
Christian Kuhn voted on patch set 3 CR +2 V +2 08/20/17, 12:29
-
Gerrit merged patch set 3 08/20/17, 12:29
-
Christian Kuhn commented on patch set 4 08/20/17, 12:29
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 27b0be101e2d48acc466fd0def1afced90dcc24f -
Christian Kuhn commented on patch set 4 08/20/17, 12:30
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit e890236d64472a5cdbbd605f805fece780ab43da